Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds support for Mega Dimension DLC by introducing new Mega-Z evolution data (tempEvoId: 5) for various Pokémon, along with refactoring to improve code maintainability and handle the new evolution type.
- Adds 15 new Pokémon with Mega evolutions/Mega-Z forms to the temp evolution data
- Refactors PokeApi class to dynamically discover mega evolutions from API instead of hardcoded list
- Creates new utility module for temp evolution operations (sorting, deduplication, merging)
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
tests/tempEvos.test.js |
New test to prevent duplicate temp evolutions in static data |
static/tempEvos.json |
Adds 15 new Pokémon with temp evolutions, removes empty evolution arrays, includes new Mega-Z forms with tempEvoId: 5 |
static/baseStats.json |
Updates evolution formId and adds legendary/mythic flags for specific Pokémon |
src/utils/tempEvolutions.ts |
New utility module providing functions for sorting, deduplicating, and merging temp evolutions |
src/classes/Translations.ts |
Adds fallback translation support for TEMP_EVOLUTION_MEGA_Z when not in proto definitions |
src/classes/Pokemon.ts |
Integrates new utility functions and adds handling for TEMP_EVOLUTION_MEGA_Z tempEvoId resolution |
src/classes/PokeApi.ts |
Major refactoring: extracts helper methods, fixes regex bug in name replacement, dynamically discovers mega evolutions, and adds Mega-Z support |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 8 out of 8 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.