Skip to content

Basic support for map plugin#19

Open
clemsos wants to merge 2 commits intoWardCunningham:masterfrom
clemsos:master
Open

Basic support for map plugin#19
clemsos wants to merge 2 commits intoWardCunningham:masterfrom
clemsos:master

Conversation

@clemsos
Copy link

@clemsos clemsos commented Nov 12, 2016

Hello,

I finally found time to play a bit with the react wiki client : very nice !
I decided to try a first implementation of the map plugin. Currently, it still only support markers / tiles.

You can see it live here http://clementrenaud.com/small-client-wiki//#small.bay.wiki.org/welcome-visitors/small.bay.wiki.org/about-map-plugin/small.bay.wiki.org/aerial-map/small.bay.wiki.org/topo-map

TODOs

  • resolve text links in marker popup
  • support map properties (caption, zoom & bounds for the whole figure)
  • support LINEUP
  • support WEBLINK
  • support BOUNDARY

@WardCunningham
Copy link
Owner

Thanks for taking this on. Here is a snapshot of @clemsos's example.

image

@clemsos
Copy link
Author

clemsos commented Nov 14, 2016

No problem, super interesting to work on that :)

A few questions concerning the remaning TODOs

  • Do you have examples of WEBLINK an BOUNDARIES in use - so I can test them ?
  • The LINEUP features requires some thoughts about how to expose data from the lineup via React props. My wild guess is that we may need to introduce something like a Redux or Reflux store to manage that - but it may also be out of the scope of this project.

@WardCunningham
Copy link
Owner

The javascript for plugins has moved and will move again into their own files. Sorry to break your pull request. This is a small project growing up.

I've added the testing-map-enhancements from my earlier development. This has some of the map markup keywords but maybe not all. I can keep looking. Here first for localhost and then for read-write wiki which we are duplicating.

http://localhost:3000/#small.bay.wiki.org/welcome-visitors/small.bay.wiki.org/about-small-client-wiki/small.bay.wiki.org/test-cases/small.bay.wiki.org/testing-map-enhancements

http://small.bay.wiki.org/view/welcome-visitors/view/about-small-client-wiki/view/test-cases/view/testing-map-enhancements

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants