Skip to content

feat: adds expiry to proposal payload #193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ganchoradkov wants to merge 3 commits into
base: main-lfs-DO-NOT-USE
Choose a base branch
from
Open

feat: adds expiry to proposal payload #193

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1235cf7
feat: adds expiry to proposal payload
ganchoradkov Jan 15, 2024
d76014e
refactor: updates expiry to expiryTimestamp
ganchoradkov Jan 18, 2024
7e46a95
feat: adds expiryTimestamp to session request
ganchoradkov Jan 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion docs/specs/clients/sign/data-structures.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,8 @@ Proposal is sent by the proposer client to be approved or rejected by the respon
"events": [string]
}
},
"pairingTopic": string
"pairingTopic": string,
"expiryTimestamp": number, // OPTIONAL timespamp in seconds
Copy link
Copy Markdown
Contributor

@jakubuid jakubuid Jan 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should add expiryTimestamp on json rpc section for session proposal and session request

}
```

Expand Down
5 changes: 3 additions & 2 deletions docs/specs/clients/sign/session-events.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ For a properly formatted namespace, refer to the documentation [here](../../../s
"params": {
"id": 1675734656244887,
"pairingTopic": "3c74583111ab5e006b03cbb0f252c667686e9fc01e675dff90aa8b18ec435feb",
"expiry": 1675734962,
"expiryTimestamp": 1675734962,
"requiredNamespaces": {
"eip155": {
"methods": [
Expand Down Expand Up @@ -164,7 +164,8 @@ Here's an example of a payload from a `session_request` when the request is for
}
]
},
"chainId": "eip155:5"
"chainId": "eip155:5",
"expiryTimestamp": 1675734962
}
}
```
Expand Down