Skip to content

refactor: pairing methods #189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ganchoradkov wants to merge 1 commit into
base: main-lfs-DO-NOT-USE
Choose a base branch
from
Open

refactor: pairing methods #189

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions docs/specs/clients/core/pairing/pairing-methods.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
## 1. Peer B matches URI's list exactly

### Peer A's pairing uri:
uri = "...methods=[wc_sessionPropose],[wc_authRequest,wc_authBatchRequest]"
uri = "...methods=wc_sessionPropose,wc_authRequest,wc_authBatchRequest"


### Peer B's registered methods:
Expand All @@ -18,7 +18,7 @@ is valid? Yes
## 2. Peer B matches one inner array exactly and partially matches another inner array

### Peer A's pairing uri:
uri = "...methods=[wc_sessionPropose],[wc_authBatchRequest]"
uri = "...methods=wc_sessionPropose,wc_authBatchRequest"


### Peer B's registered methods:
Expand All @@ -32,7 +32,7 @@ is valid? Yes
## 3. Peer B contains more methods than URI's list of methods

### Peer A's pairing uri:
uri = "...methods=[wc_sessionPropose]"
uri = "...methods=wc_sessionPropose"


### Peer B's registered methods:
Expand All @@ -46,7 +46,7 @@ is valid? Yes
## 4. Peer B matches an inner array and does not partially match the other inner array

### Peer A's pairing uri:
uri = "...methods=[wc_sessionPropose],[wc_authRequest]"
uri = "...methods=wc_sessionPropose,wc_authRequest"


### Peer B's registered methods:
Expand All @@ -60,11 +60,11 @@ is valid? No
## 5. Peer B does not match any inner arrays

### Peer A's pairing uri:
uri = "...methods=[wc_sessionPropose],[wc_authRequest]"
uri = "...methods=wc_sessionPropose,wc_authRequest"


### Peer B's registered methods:
var registeredMethods = [{ method = "wc_sessionProposeV2", type = ProtocolType.Sign },{ method = "wc_authBatchRequest", type = ProtocolType.Auth }]


is valid? No
is valid? No