Divyanshu | Design Improvements #515
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,7 +0,0 @@ | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,25 @@ | ||
| import { Injectable, inject, signal } from '@angular/core'; | ||
| import { UiSettingsService } from './ui-settings.service'; | ||
|
|
||
| @Injectable({ providedIn: 'root' }) | ||
| export class SideNavService { | ||
| private uiSettings = inject(UiSettingsService); | ||
|
|
||
| public isSideNavOpen = signal<boolean>(this.uiSettings.sideNavOpen); | ||
|
|
||
| public toggle(): void { | ||
| const next = !this.isSideNavOpen(); | ||
| this.isSideNavOpen.set(next); | ||
| this.uiSettings.setSideNavOpen(next); | ||
| } | ||
|
|
||
| public open(): void { | ||
| this.isSideNavOpen.set(true); | ||
| this.uiSettings.setSideNavOpen(true); | ||
| } | ||
|
|
||
| public close(): void { | ||
| this.isSideNavOpen.set(false); | ||
| this.uiSettings.setSideNavOpen(false); | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,64 @@ | ||
| import { Injectable } from '@angular/core'; | ||
|
|
||
| export type AppTheme = 'light-theme' | 'dark-theme'; | ||
|
|
||
| interface UiSettings { | ||
| theme: AppTheme; | ||
| sideNavOpen: boolean; | ||
| _savedAt: number; | ||
| } | ||
|
|
||
| const STORAGE_KEY = 'ui-settings'; | ||
| const TTL_MS = 30 * 24 * 60 * 60 * 1000; // 30 days | ||
|
|
||
| const DEFAULTS: Omit<UiSettings, '_savedAt'> = { | ||
| theme: 'light-theme', | ||
| sideNavOpen: true, | ||
| }; | ||
|
|
||
| @Injectable({ providedIn: 'root' }) | ||
| export class UiSettingsService { | ||
| private _settings: UiSettings; | ||
|
|
||
| constructor() { | ||
| this._settings = this._load(); | ||
| } | ||
|
|
||
| get theme(): AppTheme { | ||
| return this._settings.theme; | ||
| } | ||
|
|
||
| get sideNavOpen(): boolean { | ||
| return this._settings.sideNavOpen; | ||
| } | ||
|
|
||
| setTheme(value: AppTheme): void { | ||
| this._settings.theme = value; | ||
| this._save(); | ||
| } | ||
|
|
||
| setSideNavOpen(value: boolean): void { | ||
| this._settings.sideNavOpen = value; | ||
| this._save(); | ||
| } | ||
|
|
||
| private _load(): UiSettings { | ||
| try { | ||
| const raw = localStorage.getItem(STORAGE_KEY); | ||
| if (raw) { | ||
| const parsed: UiSettings = JSON.parse(raw); | ||
| if (parsed._savedAt && Date.now() - parsed._savedAt < TTL_MS) { | ||
| return { ...DEFAULTS, ...parsed }; | ||
| } | ||
| } | ||
| } catch { | ||
| // corrupted storage — fall through to defaults | ||
| } | ||
| return { ...DEFAULTS, _savedAt: Date.now() }; | ||
| } | ||
|
|
||
| private _save(): void { | ||
| this._settings._savedAt = Date.now(); | ||
| localStorage.setItem(STORAGE_KEY, JSON.stringify(this._settings)); | ||
| } | ||
| } |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The SideNavService and UiSettingsService are imported but not included in the component's imports array. Make sure to add them to ensure proper dependency declaration.