-
Notifications
You must be signed in to change notification settings - Fork 2
fix disign issue #512
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix disign issue #512
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -63,11 +63,13 @@ | |||||
| <ng-container matColumnDef="permissions"> | ||||||
| <th mat-header-cell *matHeaderCellDef>Permissions</th> | ||||||
| <td mat-cell *matCellDef="let element" data-label="Permissions"> | ||||||
| <div class="flex flex-wrap gap-1.5 py-2"> | ||||||
| <mat-chip-set> | ||||||
| @for (permission of element.permissionsList; track permission.name) { | ||||||
| {{ permission.name }} | ||||||
| <mat-chip> | ||||||
| {{ permission.name }} | ||||||
| </mat-chip> | ||||||
| } | ||||||
| </div> | ||||||
| </mat-chip-set> | ||||||
| </td> | ||||||
| </ng-container> | ||||||
|
|
||||||
|
|
@@ -235,31 +237,26 @@ | |||||
|
|
||||||
| <!-- ── Snippet Tab ── --> | ||||||
| @if (selectedSectionIndex === 2) { | ||||||
| <div class="flex flex-col gap-4 max-w-2xl"> | ||||||
| <div class="flex flex-col gap-4"> | ||||||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Removing the max-width constraint from the snippet container could make code snippets stretch too wide on larger screens, reducing readability. Consider keeping a reasonable maximum width. |
||||||
| <div class="card-with-header"> | ||||||
| <div class="card-with-header--header justify-between"> | ||||||
| <div class="flex items-center gap-2"> | ||||||
| <mat-icon class="!text-base !w-4 !h-4 secondary-text-color opacity-70">code</mat-icon> | ||||||
| <mat-icon class="!text-base !w-4 mt-1">code</mat-icon> | ||||||
| <span class="mat-body-2 font-semibold">Integration Script</span> | ||||||
| </div> | ||||||
| <proxy-copy-button [copyData]="userManagementScript" tooltip="Copy Script"></proxy-copy-button> | ||||||
| </div> | ||||||
| <div class="bg-color overflow-auto code-snippet-view"> | ||||||
| <markdown [data]="userManagementScript | language: 'javascript'"></markdown> | ||||||
| </div> | ||||||
| <div class="bg-color flex gap-2 px-4 py-3 border-t border-color bg-color"> | ||||||
| <mat-icon class="!text-sm !w-3.5 !h-3.5 secondary-text-color opacity-60 shrink-0 mt-0.5" | ||||||
| >info</mat-icon | ||||||
| > | ||||||
| <p class="mat-body-2 text-secondary m-0 text-xs"> | ||||||
| Add this script to your page to integrate the user management component. | ||||||
| </p> | ||||||
| </div> | ||||||
| <p class="mat-body-2 text-color px-4 py-3 m-0 text-xs"> | ||||||
| Add this script to your page to integrate the user management component. | ||||||
| </p> | ||||||
| </div> | ||||||
| <div class="card-with-header"> | ||||||
| <div class="card-with-header--header justify-between"> | ||||||
| <div class="flex items-center gap-2"> | ||||||
| <mat-icon class="!text-base !w-4 !h-4 secondary-text-color opacity-70">html</mat-icon> | ||||||
| <mat-icon>html</mat-icon> | ||||||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The HTML icon is missing the same sizing classes that are applied to the code icon above it. This will cause inconsistent icon sizing in the UI.
Suggested change
|
||||||
| <span class="mat-body-2 font-semibold">Container HTML</span> | ||||||
| </div> | ||||||
| <proxy-copy-button [copyData]="userProxyContainerHtml" tooltip="Copy Code"></proxy-copy-button> | ||||||
|
|
@@ -275,7 +272,7 @@ | |||||
| <!-- ── Settings Tab ── --> | ||||||
| @if (selectedSectionIndex === 3) { | ||||||
| <div class="max-w-xl"> | ||||||
| <p class="mat-body-2 text-secondary font-medium mb-6">Default Roles</p> | ||||||
| <p class="mat-body-2 font-medium mb-6">Default Roles</p> | ||||||
| <form [formGroup]="defaultRolesForm" class="flex flex-col gap-6"> | ||||||
| <mat-card class="outline-card p-5"> | ||||||
| <mat-card-content class="flex items-start gap-3 !p-0"> | ||||||
|
|
||||||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change removes several styling classes (
font-mono text-xs px-2 py-0.5 rounded-4 min-w-[150px]) that affect the appearance of the reference ID display. Was this intentional? If the goal was just to change the cursor style, you might want to keep the other styling classes to maintain the visual design.