Merged
Conversation
Collaborator
dvCodeWorld
commented
Apr 1, 2026
dvCodeWorld
commented
- Replace BehaviorSubject with signal for isSideNavOpen state management
- Update template to use signal syntax instead of async pipe
- Improve user profile section layout with better spacing and text overflow handling
- Add tooltip to user profile button showing full display name
- Update dark theme color variable from neutral-40 to neutral-80
- Add CSS rule for full-width button label support
- Remove unused BehaviorSubject import
- Replace BehaviorSubject with signal for isSideNavOpen state management - Update template to use signal syntax instead of async pipe - Improve user profile section layout with better spacing and text overflow handling - Add tooltip to user profile button showing full display name - Update dark theme color variable from neutral-40 to neutral-80 - Add CSS rule for full-width button label support - Remove unused BehaviorSubject import
![windsurf-bot[bot]](https://avatars.githubusercontent.com/in/1066231?s=60&v=4){kind=small}
| <proxy-main-left-side-nav | ||
| class="mat-drawer-nav proxy-left-menu" | ||
| [isSideNavOpen]="!(isSideNavOpen | async)" | ||
| [isSideNavOpen]="!isSideNavOpen()" |
There was a problem hiding this comment.
There appears to be a potential logic issue with the isSideNavOpen property passed to the proxy-main-left-side-nav component. The component receives [isSideNavOpen]="!isSideNavOpen()", which negates the value. This might be intentional, but it's worth confirming that the child component expects the inverse of the parent's state to function correctly.
| {{ user.displayName }} | ||
| </h6> | ||
| </div> | ||
| <mat-icon class="mx-1 material-icons-outlined">keyboard_arrow_up</mat-icon> |
There was a problem hiding this comment.
The user profile button shows a fixed keyboard_arrow_up icon regardless of whether the menu is open or closed. Consider making this dynamic like the client menu icon:
Suggested change
| <mat-icon class="mx-1 material-icons-outlined">keyboard_arrow_up</mat-icon> | |
| <mat-icon class="mx-1 material-icons-outlined">{{ menu?.menuOpen ? 'keyboard_arrow_up' : 'keyboard_arrow_down' }}</mat-icon> |
Saurabh186
approved these changes
Apr 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.