Conversation
![windsurf-bot[bot]](https://avatars.githubusercontent.com/in/1066231?s=60&v=4){kind=small}
| </button> | ||
| <mat-menu #menu="matMenu" class="profile-menu ml-1"> | ||
| <h4 class="m-0 py-2 px-6 text-dark font-medium">{{ user.displayName }}</h4> | ||
| <div mat-menu-item class="flex items-center gap-2" (click)="switchedDarkMode(!isDarkMode())"> |
There was a problem hiding this comment.
The dark mode toggle has been moved to the user menu, which improves the UI. However, the function call has changed from switchedDarkMode($event.checked) to switchedDarkMode(!isDarkMode()). Make sure the function can handle a direct boolean parameter instead of an event object.
| // .mat-mdc-cell { | ||
| // border-bottom-color: var(--color-table-cell-border) !important; | ||
| // } |
There was a problem hiding this comment.
Instead of commenting out CSS rules that are no longer needed, it would be better to remove them completely. Commented code adds maintenance burden and can cause confusion for other developers. If these styles need to be referenced later, they can be found in version control history.
| width: 100%; | ||
| padding: 8px 16px !important; | ||
| border-bottom: 1px solid var(--color-table-cell-border) !important; | ||
| // border-bottom: 1px solid var(--color-table-cell-border) !important; |
There was a problem hiding this comment.
Similarly here, if the border-bottom style is no longer needed, it should be removed rather than commented out.
2 participants
No description provided.