Skip to content

Divyanshu/Saurabh | Design issue fix#508

Merged
Saurabh186 merged 5 commits intodevelopmentfrom
divyanshu-dev
Mar 31, 2026
Merged

Divyanshu/Saurabh | Design issue fix#508
Saurabh186 merged 5 commits intodevelopmentfrom
divyanshu-dev

Conversation

@dvCodeWorld
Copy link
Copy Markdown
Collaborator

Self

Saurabh186 and others added 5 commits March 31, 2026 14:44
- Replace `broder-color` typo with `border-color` throughout templates
- Introduce `card-with-header` and `card-with-header--header` utility classes for consistent card styling
- Remove inline background color utilities in favor of `bg-color` class
- Remove unused `preview-input-field` styles from SCSS
- Remove `max-width` constraint from code snippet view
- Simplify chip and badge styling by removing redundant color utilities
- Update
Copy link
Copy Markdown

@windsurf-bot windsurf-bot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other comments (9)

💡 To request another review, post a new comment with "/windsurf-review".

Comment on lines 3 to 4
min-width: 500px;
max-width: 800px;
}
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing the max-width constraint from .code-snippet-view might cause content to stretch too wide on larger screens. Consider if this was intentional or if a different max-width value would be more appropriate to maintain readability.

@@ -1,5 +1,5 @@
@if (loading$ | async; as loading) {
<div class="app-content flex flex-col">
<div class="flex flex-col">
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The app-content class has been removed from the main container div. Ensure this doesn't break the component's layout within the application context, especially regarding padding, margins, or other layout properties that might have been provided by this class.

}
</div>
<div class="flex-1 flex flex-col overflow-hidden">
<div class="flex-1 flex flex-col app-content">
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The overflow-hidden property was removed from the content container. This might cause content to overflow its container when there's a lot of data. Consider adding appropriate overflow handling to the app-content class.

@Saurabh186 Saurabh186 merged commit 9b14d56 into development Mar 31, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants