feat: add DELETE /collection/:id/resources endpoint#835
Open
Husainbw786 wants to merge 1 commit intotestingfrom
Open
feat: add DELETE /collection/:id/resources endpoint#835Husainbw786 wants to merge 1 commit intotestingfrom
Husainbw786 wants to merge 1 commit intotestingfrom
Conversation
Contributor
|
PR review rate limit exceeded |
ea9d13f to
1330e97
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Added a new DELETE endpoint for deleting resources from a collection by owner ID.
New endpoint:
DELETE /collection/:id/resources?ownerId=<ownerId>Changes made:
deleteResourcesByCollectionAndOwnercontroller function inrag.controller.jsdeleteResourcesByCollectionQuerySchemavalidation schema inrag.validation.jsrag.routes.jsWhy
To support deleting resources from a collection based on the collection ID and owner ID. This follows the existing pattern used for other RAG endpoints.
Notes
DELETE /collection/:collectionId/resources?ownerId=<ownerId>middlewareandcheckAgentAccessMiddlewareconsistent with other resource management endpointsownerIdis required as a query parameter