Front end #20
Front end #20
Conversation
rajwinderb
left a comment
rajwinderb
left a comment
There was a problem hiding this comment.
Everything works great and is well programmed, we just need to wait for some things in main and neaten up where things are!! This will be done in a new branch we create!
| print("Successful Registration!") | ||
| print("") | ||
|
|
||
|
|
There was a problem hiding this comment.
Might be better to have this in a separate file when we get to writing the user interface properly.
But I really like the exception handling!!!!
| class DbConnectionError(Exception): | ||
| pass | ||
|
|
||
| #DB Connection |
There was a problem hiding this comment.
All db connection things to be moved to db_utils
There was a problem hiding this comment.
I'll do that over the weekend :)
|
|
||
|
|
||
| #Function to register new user details into the DB | ||
| def new_registration(first_name,last_name,email,password): |
| print("") | ||
|
|
||
|
|
||
| #menu function |
There was a problem hiding this comment.
Brill way to start the UI
There was a problem hiding this comment.
Thank you!! Once I've migrates stuff to db.utils, as per your rec, we could delete the branch and create a new one for review with the wider team.
|
Brilliant work! @Laksh-13 It works well here too! I spent a bit of time figuring out how to execute the code. Just a note here that we will need to write in README later how to run the code. |
| host = "localhost", | ||
| user = "root", | ||
| passwd = "password", #Reviewer Password | ||
| database = "walk2zero" |
There was a problem hiding this comment.
After moving to db_utils.py, we will need to import variables from the config.py file from config import USER, PASSWORD, HOST, and change string values to those variables
-It's a very initial UI and I am yet to add a function that asks for user vehicle registration.
-It is going to be a WIP with more functions that can be added as the project builds.
-getpass() is a lib-function that should either not display your password when typing or print a ***.
-You will have to help me out with the git push because I don't know why but I've accidentally pushed DB files on this branch as well. Thanks!