feat: add missing and fix incorrect Calendar 1999 challenge translations#810
Conversation
Add: - CalendarKillEnemiesHard (Even the odds / Kill 1,000 Enemies) - CalendarKillEnemiesWithAbilitiesEasy (Demonstration of power / Kill 150 Enemies with Abilities) - CalendarKillEnemiesWithMeleeHard (By The Blade / Kill 500 Enemies with Melee Weapons) - CalendarKillEnemiesWithMeleeMedium (By The Blade / Kill 300 Enemies with Melee Weapons) - CalendarKillEximusMedium (EX-EXIMUS / Kill 20 Eximus) - CalendarKillScaldraEnemiesWithMeleeHard (Make it personal / Kill 250 Scaldra Troops with Melee Weapons) - CalendarKillTechrotEnemiesWithAbilitiesEasy (Null and Void / Kill 100 Techrot with Abilities) - CalendarKillTechrotEnemiesWithAbilitiesHard (Null and Void / Kill 300 Techrot with Abilities) - CalendarKillTechrotEnemiesWithMeleeEasy (Electronic waste Disposal / Kill 100 Techrot with Melee Weapons) - CalendarKillTechrotEnemiesWithMeleeHard (Electronic waste Disposal / Kill 300 Techrot with Melee Weapons) Fix: - CalendarKillScaldraEnemiesEasy: 250 -> 150 Scaldra Troops - CalendarKillScaldraEnemiesWithMeleeMedium: 300 -> 150 Scaldra Troops with Melee Weapons - CalendarKillTechrotEnemiesHard: 1,000 -> 750 Techrot
📝 WalkthroughWalkthroughThis PR modifies Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@data/languages.json`:
- Around line 563-570: The JSON shows the keys CalendarKillEximusEasy and
CalendarKillEximusHard changed their "value" from "EX-EXIMUS" to "Ex-Eximus";
verify the correct in-game casing for Eximus (check game assets or localization
source) and then either (a) update the PR description to reflect the new
"Ex-Eximus" text (including the Medium entry mention) or (b) revert the two
entries back to "EX-EXIMUS" if the original was correct; reference
CalendarKillEximusEasy, CalendarKillEximusMedium, and CalendarKillEximusHard
when making the PR description or JSON update so all three entries are
consistent.
|
🎉 This PR is included in version 3.4.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Add:
Fix:
Data taken from https://wiki.warframe.com/w/1999_Calendar
Considerations
Summary by CodeRabbit
New Features
Updates