-
Notifications
You must be signed in to change notification settings - Fork 0
Brian/deep object detection #26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…config issues and removed other launch files TODO: Allow dynamic batch sizes. Optimize!
Edwardius
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
BackendManager needs to not exist, these nodes should not need any backend-specific logic to function. Actually, the reason why is because this node is not a BASE CLASS of DeepNodeBase. Can you do that?
Also, please note that AI generated code is still YOUR code at the end of the day. Other people read it like its code written by you, so you should be more careful of when AI is creating code patterns that would never have happenned if you wrote it completely from scratch. Otherwise, your making others review AI code for you, and thats not fair.
deep_object_detection/include/deep_object_detection/backend_manager.hpp
Outdated
Show resolved
Hide resolved
deep_object_detection/include/deep_object_detection/detection_types.hpp
Outdated
Show resolved
Hide resolved
deep_object_detection/include/deep_object_detection/detection_types.hpp
Outdated
Show resolved
Hide resolved
|
summary of changes:
next things:
|
Edwardius
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tiny things now, otherwise LGTM!
things that are supported:
tested with yolov8m.onnx and camera_sync, publishing at ~30hz with tensorrt ep