Implement course details feature #21
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds the core components for the course details screen. - Creates `CourseDetailsScreen.kt` for the main user interface. - Implements `CourseDetailsViewModel.kt` to manage the screen's logic and data. - Defines `CourseDetailsUIState.kt` for state representation. - Adds `course_details_image.jpg` and `instructor_sarah.xml` as visual assets. - Modifies `MainActivity.kt` to handle navigation to the new screen.
# Conflicts: # app/src/main/java/org/mahd_e_learning_platform/presentation/MainActivity.kt # app/src/main/res/values/strings.xml
# Conflicts: # app/src/main/java/org/mahd_e_learning_platform/presentation/MainActivity.kt
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR implements a new course details feature by introducing a dedicated screen, view model, and UI state along with supporting assets and navigation updates.
- Adds CourseDetailsScreen.kt to display course details using Jetpack Compose.
- Implements CourseDetailsViewModel.kt and CourseDetailsUiState.kt for business logic and state representation.
- Updates MainActivity.kt to handle navigation and integrates visual assets.
Reviewed Changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| app/src/main/res/values/strings.xml | Added string resource for "Course Details" |
| app/src/main/res/drawable/instructor_sarah.xml | Introduced a new vector drawable asset for the instructor image |
| app/src/main/java/org/mahd_e_learning_platform/presentation/screens/course_details/CourseDetailsViewModel.kt | Created a view model with toggle functionality and placeholder TODOs |
| app/src/main/java/org/mahd_e_learning_platform/presentation/screens/course_details/CourseDetailsUiState.kt | Defined UI state data classes for the course details screen |
| app/src/main/java/org/mahd_e_learning_platform/presentation/screens/course_details/CourseDetailsScreen.kt | Built the UI components and layout in Jetpack Compose |
| app/src/main/java/org/mahd_e_learning_platform/presentation/MainActivity.kt | Updated navigation logic and removed commented splash screen code |
Comment on lines
+36
to
+38
| // splashScreen.setKeepOnScreenCondition { | ||
| // false | ||
| // } |
There was a problem hiding this comment.
Consider removing commented-out splashScreen.setKeepOnScreenCondition code if it is no longer needed to maintain a clean codebase.
Suggested change
| // splashScreen.setKeepOnScreenCondition { | |
| // false | |
| // } |
| Text(instructor.title, style = MaterialTheme.typography.bodyMedium, color = Color.Gray) | ||
| } | ||
| } | ||
| TextButton(onClick = onToggleFollow, colors = ButtonDefaults.textButtonColors(contentColor = MahdELearningPlatformTheme.colors.primary) // Corrected line |
There was a problem hiding this comment.
[nitpick] Remove the inline comment '// Corrected line' from the TextButton declaration to keep the production code clean and clear.
Suggested change
| TextButton(onClick = onToggleFollow, colors = ButtonDefaults.textButtonColors(contentColor = MahdELearningPlatformTheme.colors.primary) // Corrected line | |
| TextButton(onClick = onToggleFollow, colors = ButtonDefaults.textButtonColors(contentColor = MahdELearningPlatformTheme.colors.primary) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the core components for the course details screen.
CourseDetailsScreen.ktfor the main user interface.CourseDetailsViewModel.ktto manage the screen's logic and data.CourseDetailsUIState.ktfor state representation.course_details_image.jpgandinstructor_sarah.xmlas visual assets.MainActivity.ktto handle navigation to the new screen.