just use the repository c3po is called with and override existing setting#3
Open
gcetusic wants to merge 2 commits intoVorskiImagineering:masterfrom
gcetusic:misc_fixes
Open
just use the repository c3po is called with and override existing setting#3gcetusic wants to merge 2 commits intoVorskiImagineering:masterfrom gcetusic:misc_fixes
gcetusic wants to merge 2 commits intoVorskiImagineering:masterfrom
gcetusic:misc_fixes
Conversation
Collaborator
|
The GIT_REPOSITORY setting is important when you use django-c3po as tool for another project (not necessarily django project). I find trying to add, removing and adding again a little bit offensive. What about my suggestion #2 (comment) ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since django-c3po has a setting GIT_REPOSITORY that's used when calling git_push, I think users expect THAT repository to be used. I'm guessing django-c3po users have no idea what exactly git_push does, shouldn't be bothered with git configuration beyond settings and C3PO should override .git/config since it added it in the first place so "remote show" line should be evicted entirely.