Skip to content

fix: raise exception when response has an error #539

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cojdev merged 4 commits into from
Jan 14, 2025
Merged

fix: raise exception when response has an error #539

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
fb13b6e
fix: raise exception when response has an error
cojdev Jan 13, 2025
44008e5
chore: version bump
cojdev Jan 13, 2025
0f13075
chore: remove print
cojdev Jan 14, 2025
bc34d2e
chore: specific exception type
cojdev Jan 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion vortexasdk/client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
from typing import Any, Dict, List, Optional
from urllib.parse import urlencode

from requests import Response
from requests import Response, RequestException
from tqdm import tqdm

from vortexasdk import __name__ as sdk_pkg_name
Expand Down Expand Up @@ -82,6 +82,10 @@ def search_base(
probe_response = _send_post_request(
url, payload, size=1, headers=headers
)

if "error" in probe_response:
raise RequestException(probe_response)

total = self._calculate_total(probe_response)

if total > self._MAX_ALLOWED_TOTAL:
Expand Down
2 changes: 1 addition & 1 deletion vortexasdk/version.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
__version__ = "1.0.4"
__version__ = "1.0.5"
Loading