Skip to content

Refactor of ConnectionRepository calls and usages in the project. #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
carlosarismendi wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Refactor of ConnectionRepository calls and usages in the project. #29

carlosarismendi wants to merge 3 commits into from

Conversation

@carlosarismendi
Copy link
Collaborator

@carlosarismendi carlosarismendi commented Mar 26, 2023

  • Moved repository calls from use cases to controllers in most actions (missing create/join room actions).
  • Added wsrouter.Context.Bind(...) method so controllers can use it to unmarshall input parameters. This way a wrapper can be added to the error.
  • Changed *shared.WsConn to be domain.ConnectionRepository in domain.Player. Removed ConnectionRepository attributes in wsrouter.Context.

@carlosarismendi carlosarismendi self-assigned this Mar 26, 2023
@carlosarismendi carlosarismendi requested a review from Visn0 March 27, 2025 07:48
Visn0
Visn0 reviewed Mar 28, 2025
View reviewed changes
Copy link
Owner

@Visn0 Visn0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where are the tests?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Visn0 Visn0 Visn0 left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@carlosarismendi carlosarismendi

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@carlosarismendi @Visn0