Stop using unofficial API for rmtree #548
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
andyneff
commented
Dec 10, 2025
andyneff
commented
- Vastly simplify rmtree by just using shutil.rmtree many times instead of trying to be super efficient and doing it all at once. Not worth the headache
- Disable git airgap int test
- Vastly simplify rmtree by just using shutil.rmtree many times instead of trying to be super efficient and doing it all at once. Not worth the headache Signed-off-by: Andy Neff <andy@visionsystemsinc.com>
Signed-off-by: Andy Neff <andy@visionsystemsinc.com>
drewgilliam
reviewed
Dec 11, 2025
- Add unit test for files in base directiry - Fix for files in base directory Signed-off-by: Andy Neff <andy@visionsystemsinc.com>
drewgilliam
approved these changes
Dec 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.