Add requirements and fix j2a-import readme instructions#1
Open
Grovespaz wants to merge 1 commit intoViolet-CLM:masterfrom
Open
Add requirements and fix j2a-import readme instructions#1Grovespaz wants to merge 1 commit intoViolet-CLM:masterfrom
Grovespaz wants to merge 1 commit intoViolet-CLM:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I had to run j2a-import to rebuild plus.j2a on a new machine and I noticed it needed some requirements that weren't installed by default. This adds them to the requirements.txt for future reference.
I also noticed that the import command wouldn't work if I didn't use the --output flag, so I added that to the readme.