Fixed event placement and added AGA events#77
Open
Assassin877 wants to merge 1 commit intoViolet-CLM:masterfrom
Open
Fixed event placement and added AGA events#77Assassin877 wants to merge 1 commit intoViolet-CLM:masterfrom
Assassin877 wants to merge 1 commit intoViolet-CLM:masterfrom
Conversation
Violet-CLM
reviewed
Nov 27, 2020
| 140=DownLeft Arrow |-|Signpost|DLeft |Arrow No newline at end of file | ||
| 140=DownLeft Arrow |-|Signpost|DLeft |Arrow | ||
|
|
||
| 141=Barrel A |-|Franks |Barrel |#1 |???:AL|???:AL|???:AL|???:AL|???:AL|???:AL|???:AL|???:AL|???:AL|???:AL|???:AL|???:AL|???:AL|???:AL|???:AH |
Owner
There was a problem hiding this comment.
Do all these remaining events really have exactly the same (very long) list of parameters? This seems improbable
Author
There was a problem hiding this comment.
They don't, I got the events by editing the bres files in Notepad++ and was unable to figure out the parameter list per event that way. I tried adding this long list for every event and it seemed to work so I chose to keep it like this rather than not have any parameters.
Violet-CLM
added a commit
that referenced
this pull request
May 15, 2021
Incorporating one change from #77. I'm not comfortable adding the extended event list from that pull request while the parameters are so inaccurate, though.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.