Conversation
lucaeyring
approved these changes
Aug 11, 2025
Collaborator
lucaeyring
left a comment
There was a problem hiding this comment.
Looks good to me, thanks for the fixes!!
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #191 +/- ##
=======================================
Coverage 75.36% 75.36%
=======================================
Files 40 40
Lines 2139 2172 +33
Branches 272 276 +4
=======================================
+ Hits 1612 1637 +25
- Misses 429 437 +8
Partials 98 98
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
lucaeyring
approved these changes
Aug 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the following bugs in the feature extraction pipeline
extract_featuresBaseExtractor.extract_features:features=defaultdict(list). This, unfortunately, deletes the intermediate results of other modules. Therefore changed tofeatures[module_name]=[]module/featuredoes not exist, then an error is thrown.save_in_one_file=True,output_diris prepended again. Which incorrect.super().extract_features--> need to addfile_name_suffixandsave_in_one_fileas arguments to be able to pass it to the parent.NEW: Dataloader modifier
PR adds a context manager for PyTorch feature extraction. Assumes that a dataloader either returns an image or a tuple of (image, *args) or a list of (image, *args). If the dataloader returns a tuple of (image, *args) or a list of (image, *args), it will return only the images. The class does not modify otherwise (e.g., specialized dataloaders).