Open
Conversation
// #AllowImGuiIni // When DISABLE_NONUFS_INI_WHEN_COOKED is defined, FPakPlatformFile::IsNonPakFilenameAllowed rejects all free .ini files except for GameUserSettings.ini via a relatively hacky code path // ImGui.ini is effectively ImGui's equivalent, so we can piggyback off of this, and read our file in packaged builds, if we name it ImGuiGameUserSettings.ini
This reverts commit b6c7e8e.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When DISABLE_NONUFS_INI_WHEN_COOKED is defined, FPakPlatformFile::IsNonPakFilenameAllowed rejects all free .ini files except for GameUserSettings.ini via a relatively hacky code path. ImGui.ini is effectively ImGui's equivalent, so we can piggyback off of this, and read our file in packaged builds, if we name it ImGuiGameUserSettings.ini
It does cause a breaking change to the file in Editor (I could go either way on that). But... if you don't name it this in packaged builds, it can't follow the allowlist codepath. So you can't have any imgui settings in builds that disable non ufs inis