-
Notifications
You must be signed in to change notification settings - Fork 99
Upgrade SDKs and Librustzcash, for both Android and iOS #220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev-asf-parent
Are you sure you want to change the base?
Conversation
…act-native metho in WalletFolder.js mocks
- Between verusmobile and react-native-verus
- Need to clean a lot of this up. Many different useless bits and pieces in here
…into maven-verus
- with verus-android-wallet-sdk artifacts
| } | ||
| } | ||
| signingConfigs { | ||
| /*signingConfigs { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be re-enabled for prod release.
| @@ -1,5 +1,5 @@ | |||
| let dlightServers = { | |||
| vrsc: ['lightwallet.verus.services:8120'], | |||
| vrsc: ['lightwalletd.whobiz.dev:443'], | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This also should be changed back before prod.
7849b59 to
c080f51
Compare
| pubKey: null, | ||
| privKey: spendingKey, | ||
| viewingKey: await VerusLightClient.deriveViewingKey(spendingKey), | ||
| viewingKey: viewKey, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should discuss if this one needs changed.
I don't know that we use V0 anywhere, but our encoded viewkey is a unified key, now (uview.... bech32m-encoded).
Easiest solution is just to not store the viewkey, since we compute these internally in RN functions that need it, from spendkey or seed.
55e4335 to
8734a61
Compare
c0eb0ca to
708e7f3
Compare
c765787 to
e6c05d5
Compare
- Also throw on hex import, since we don't yet support it on iOS - Tools.bech32Decode will also now properly propagate its if we fail to decode the string
This PR includes the supporting code for migration of Verus-mobile to:
1.) new
react-native-verusdependency (replacesverus-light-client)2.) newer versions of the SDKs for each platform
3.) newer
librustzcashas wellThis PR does not include the encryption support work done by Artist.
No known issues/errors at time of writing, but still testing.