fix(awsconfig): add file locking to prevent duplicate credential sections#1518
Open
jayjanssen wants to merge 1 commit intoVersent:masterfrom
Open
fix(awsconfig): add file locking to prevent duplicate credential sections#1518jayjanssen wants to merge 1 commit intoVersent:masterfrom
jayjanssen wants to merge 1 commit intoVersent:masterfrom
Conversation
…ions Implement exclusive file locking and atomic writes for the AWS credentials file to prevent duplicate section headers when multiple saml2aws processes run concurrently. Use flock on Unix/Linux/macOS and LockFileEx on Windows via golang.org/x/sys. Add TestConcurrentSave to verify no duplicates under load. Fixes concurrent race condition in Save() and saveProfile(). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Co-authored-by: Claude Code <noreply@anthropic.com> Ai-assisted: true
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Save()to prevent concurrent processes from creating duplicate credential sectionssaveProfile()to prevent partial writes on crashTestConcurrentSaveandTestFileLockExclusivitytests with race detector coverageTest plan
go test ./pkg/awsconfig/ -race -count=1passesGOOS=windows go build ./pkg/awsconfig/cross-compilesGOOS=linux go build ./pkg/awsconfig/cross-compilesgo build ./...full project compilessaml2aws loginprocesses, verify no duplicate sections in~/.aws/credentials🤖 Generated with Claude Code