Skip to content

Conversation

@danguite123
Copy link

Adding a pre run action option to the playbooks to be able to populate environment variables from external scripts or applications.

Adding a pre run action option to the playbooks to be able to populate environment variables from external scripts or applications.
@luispresuelVenafi
Copy link
Contributor

luispresuelVenafi commented Nov 6, 2025

Hi @danguite123 a few things:

  • Could you rebase your branch? It shows it's out of date
  • Could you make sure your commit appears as "verified"? Otherwise, you won't be able to merge this PR or even add more update:
Screenshot 2025-11-05 at 6 55 48 PM
  • Could you add some tests to this? E.g. at least add an e2e test that grabs any of these variables you are intending to be grabbed in run time? Look for example at other tests right here (using aruba + cucumber + ruby):
  • You could also try to follow this guide setup I did. Still needs work (hence not merged) to be more readable, but hope it gives you guidance what to configure so you make sure you get a successful pipeline once we run this PR against our pipeline once tests are added, thanks!:

@luispresuelVenafi luispresuelVenafi requested review from angelmoo, knikolov82 and stkomitov and removed request for rvelaVenafi November 6, 2025 01:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants