Update sample.capi.yaml #514
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BeardedPrincess
approved these changes
Sep 11, 2024
Where sanDNS was currently located it was being ignored. it needed to be bumped out of the subject for the CSR. Additionally, if it is located here it will do nothing and throw no errors. I also and an extra \ into LocalMachine\\My. in the current example it only had one which won't work and will confuse new users.
BeardedPrincess
force-pushed
the
patch-2
branch
from
d0fb905 to
d55eaed
Compare
Pmaraveyias
approved these changes
Sep 11, 2024
|
the sample CAPI YAML file still seems off for the sanDNS section in that it's still under the subject section in the request portion and not outdented under request. Customer used this example and it didn't work so found this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Where sanDNS was currently located it was being ignored. it needed to be bumped out of the subject for the CSR. Additionally, if it is located here it will do nothing and throw no errors. I also and an extra \ into LocalMachine\My. in the current example it only had one which won't work and will confuse new users.