Enables timeout for enroll operations for TLSPC and TLSPDC in VCert SDK #428
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ons for TLSPC (VaaS) and TLSPDC (TPP)
luispresuelVenafi
requested review from
EduardoVV,
marcos-albornoz and
rvelaVenafi
as code owners
luispresuelVenafi
changed the title
…anymore due to implementation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is in dependency for this issue in Venafi Provider for HashiCorp Terraform: Support Custom TimeoutsNot all of this is needed it for the consuming Venafi integrations (PKI Backend, Terraform, etc). This maybe helpful in future once we want to standardize the usage of
request.Timeoutsince as discussed with @marcos-albornoz , as able to show that there are discrepancies within the code across regarding its the usage.