fix: only change in logic

[0xMotto]

No description provided.

[c001ie]

@0xMotto changing the license too?

[0xMotto]

changes made by someone

[duncan4123]

Other licence would not verify

[c001ie]

encodeCall is better than encodeWithSelector

[Ceazor]

To-Do

in Gauge.Sol
remove claimFees() from line 721 in notifyRewardAmount()
this function is called when distribute() is called in voter.sol and it the entire source of our mess

[Ceazor]

ToDo2

in Pair.Sol
consider removing

                if (_ratio > 0) {
                index0 += _ratio; }

from both update0() and update1()
or
just set index0 to index1 inside update1()

[Ceazor]

ToDo3

in Voter.sol. review and change to the following and its interfaces

        function killGauge(address _gauge) external {
        require(msg.sender == emergencyCouncil, "not emergency council");
        require(isAlive[_gauge], "gauge already dead");
        isAlive[_gauge] = false;
        claimable[_gauge] = 0;                   <--- this should be removeable
        address _pair = IGauge(_gauge).stake();
        IPair(_pair).setHasGauge(bool false);
        emit GaugeKilled(_gauge);
    }

    function reviveGauge(address _gauge) external {
        require(msg.sender == emergencyCouncil, "not emergency council");
        require(!isAlive[_gauge], "gauge already alive");
        isAlive[_gauge] = true;
        address _pair = IGauge(_gauge).stake();
        IPair(_pair).setHasGauge(bool true);
        emit GaugeRevived(_gauge);
    } 

as seen here
velodrome-finance/contracts@7219a03

[Ceazor]

ToDo4 (consider it)

In pairFactory.sol remove

       require(_fee != 0, "fee must be nonzero");

from setFees() so its possible to turn them all off.

but make sure there isnt /fee *fee issues anywhere.

            if (amount0In > 0) {
                _update0((amount0In * PairFactory(factory).getFee(stable)) / 10000);
            } // accrue fees for token0 and move them out of pool
            if (amount1In > 0) {
                _update1((amount1In * PairFactory(factory).getFee(stable)) / 10000);
             ```
this looks fine.