Port over discrete pavise aim and slam locking systems from my addon#51
Open
CreepZoneTNT wants to merge 6 commits intoVeeveene:masterfrom
Open
Port over discrete pavise aim and slam locking systems from my addon#51CreepZoneTNT wants to merge 6 commits intoVeeveene:masterfrom
CreepZoneTNT wants to merge 6 commits intoVeeveene:masterfrom
Conversation
# Conflicts: # Content/Guardian/OrchidModGuardianShield.cs
… added, and attempted to add a slam rotation lock feature (there is a small glitch where the sprite flips upside down if you slam to the left and then look right while shouldFlip is true, but it's the best I can do right now)
CreepZoneTNT
changed the title
… added, and attempted to add a slam rotation lock feature (there is a small glitch where the sprite flips upside down if you slam to the left and then look right while shouldFlip is true, but it's the best I can do right now)
# Conflicts: # Content/Guardian/GuardianShieldAnchor.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For one of the pavises in my addon I created a system that snaps the cursor to the nearest 90° angle, but it was a very hacky solution that involved fighting against the anchor's preset aiming logic. So, I thought it would come in handy if such a feature was added to Orchid's codebase itself, where it can more closely integrate with the
GuardianShieldAnchorlogic. without resorting to shenanigans.I also expanded on the concept with the option to specify more or less than 4 snap points with the
discreteAimIncrementsfield, and a way to rotate the main reference angle withdiscreteAimRotation.While I was at it, I also added a
SlamEndmethod to go along with theBlockEndmethod recently added, and - another feature from my addon - a slam rotational lock feature. (Although this one has a small glitch involvingshouldFlipthat I couldn't solve in time)