add container file detection and extraction (and small cast issue) #946
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xusheng6
requested changes
Jan 6, 2026
Member
xusheng6
left a comment
xusheng6
left a comment
There was a problem hiding this comment.
This looks great! I tested and it works smoothly. I have made a few comments -- once those are addressed this PR is good to go!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds automated detection of container files (BNDB, zip archives, virtual paths) at debug launch time, and if the original file is missing for them on the disk, prompts the user to automatically extract the binary to the disk. This makes the flow a lot nicer!
When reproducing the issue I realised the
CreateProcess2 failed: 0x..error code was wrong because they were signedHSRESULTvalues, now they are casted touint32_t.This PR will close #925