WIP: [IMP] session_db: Add a way to parse binary data from session data#167
Open
JonathanOsAlc wants to merge 6 commits intoVauxoo:16.0from
Open
WIP: [IMP] session_db: Add a way to parse binary data from session data#167JonathanOsAlc wants to merge 6 commits intoVauxoo:16.0from
JonathanOsAlc wants to merge 6 commits intoVauxoo:16.0from
Conversation
846fe5e to
5c07589
Compare
6ee9f42 to
6e83a37
Compare
6e83a37 to
f5a8872
Compare
|
Do you think it could be std for OCA? |
Author
Yes, I think so. |
f5a8872 to
25580a2
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 16.0 #167 +/- ##
=======================================
Coverage ? 84.31%
=======================================
Files ? 34
Lines ? 1039
Branches ? 119
=======================================
Hits ? 876
Misses ? 121
Partials ? 42 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
25580a2 to
9fa9191
Compare
a0dbe34 to
ba19b2e
Compare
|
Could you create the PR to OCA and tag to the authors, please? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the issue/feature this PR addresses:
Current behaviour before PR:
session_dbmodule, it triggers an error because the binary value can't be written to the database ofsession_db.intorfloatand Odoo wants to render that value like monetary.Desired behavior after PR is merged:
base64::to the string.OCA PR: OCA#3496