feat[#104]: Firstly ask for a language#404
Open
muhdsalm wants to merge 2 commits intoVanilla-OS:mainfrom
Open
Conversation
Member
|
In this case I think marking the PR as a draft is better to prevent anyone from merging. |
Contributor
Author
|
This PR isn't exactly draft - it's feature-completed. It just looks weird because of how laggy vanilla-installer is. Hopefully #405 fixes that. |
Member
|
Ya in this case marking as a draft is just to avoid merging it alone. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #104
This merge makes the app behave a bit weirdly, but I think it's caused by the installer's overall performance issues. I have an idea to address the performance issues, and I'll send it in a PR soon. Probably best to merge that one before this one.