ExperienceRequiredForLevel optimization#30
Open
Kusko25 wants to merge 1 commit intoVanilla-Expanded:mainfrom
Open
ExperienceRequiredForLevel optimization#30Kusko25 wants to merge 1 commit intoVanilla-Expanded:mainfrom
Kusko25 wants to merge 1 commit intoVanilla-Expanded:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I notice a visible performance hit when my pawns were meditating and decided to look into it a bit.
The way I understand it every tick a pawn is meditating it calls GainExperience -> ExperienceRequiredForLevel, which recursively calls itself 'level' times to produce the answer. Ideally that result should be cached so the calculation only needs to be made once, but I don't know enough about c# to do that, so instead I reduced it to two math operations and removed the recursion.
This is my first time having a deeper look at Rimworld c# modding, so I couldn't test this and don't know if it will actually have a positive impact, so I present it for your consideration in the hope it's helpful.
Love the mod and all of your hard work