Remove KCSG GenStep_Power patch#167
Open
a-certain-existence wants to merge 1 commit intoVanilla-Expanded:mainfrom
Open
Remove KCSG GenStep_Power patch#167a-certain-existence wants to merge 1 commit intoVanilla-Expanded:mainfrom
GenStep_Power patch#167a-certain-existence wants to merge 1 commit intoVanilla-Expanded:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, KCSG has already patched
{Settlement,MapParent}.MapGeneratorDefwith customMapGeneratorDefs that do not useGenStep_Poweranymore, so this patch doesn’t seem to be useful anymore.Further more, this patch could prevent other mods with custom map generator from generating power grids correctly. One example would be RimCities, which overrides
Settlement.MapGeneratorDefin the subclassCityand still usesGenStep_Power. So you could get a map without power grids. This PR will fix this issue.