New VEF_VerbRangeFactor stat implementation#164
Open
a-certain-existence wants to merge 1 commit intoVanilla-Expanded:mainfrom
Open
New VEF_VerbRangeFactor stat implementation#164a-certain-existence wants to merge 1 commit intoVanilla-Expanded:mainfrom
VEF_VerbRangeFactor stat implementation#164a-certain-existence wants to merge 1 commit intoVanilla-Expanded:mainfrom
Conversation
a-certain-existence
force-pushed
the
new-weapon-range-factor-implementation
branch
3 times, most recently
from
d7e06f7 to
f04908e
Compare
a-certain-existence
force-pushed
the
new-weapon-range-factor-implementation
branch
from
f04908e to
edeab7d
Compare
a-certain-existence
changed the title
VEF_VerbRangeFactor stat implementation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR proposes a new implementation for
VEF_VerbRangeFactorstat, and fixes an issue that multiple pawns can’t be ordered to aim at the same target in a batch if:This issue affects mods that uses
VEF_VerbRangeFactor, like Alpha Memes, Vanilla Skills Expanded and Vanilla Quests Expanded - Ancients.I have tested this locally against ranged weapons and apparels that provide ranged weapons, it seems to work fine. Range indicators are correctly drawn, melee weapons and turret buildings are correctly ignored.