Reorganization of some Shape .ts files#23
Open
Connierollstheball wants to merge 1 commit intoVanilagy:masterfrom
Open
Reorganization of some Shape .ts files#23Connierollstheball wants to merge 1 commit intoVanilagy:masterfrom
Connierollstheball wants to merge 1 commit intoVanilagy:masterfrom
Conversation
Imo, there's no reason why there should be really small .ts files defining stuff that could very well just... exist in another .ts file (per example, Small Duct Fans shouldn't have their own .ts file, but should be part of duct_fan.ts, same thing with all the Signs). It'd also make things more organized (all Duct Fan instances in one file, all Sign instances in one file, all Bumper instances in one file).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While messing around in the files, I noticed that there were some small .ts files that didn't really make sense (at least to me) to exist on their own. I think it would be just a bit better if stuff like Small Duct Fans or Round Bumpers were initiated/defined/whatever-the-right-keyword-is in
duct_fan.tsandabstract_bumper.tsinstead of them having their own standalone .ts files.I've done this for Bumpers, Signs, and Duct Fans.
I've also tested this and noticed no performance drops.