Draft
Conversation
- Add 'line' to getPrimaryChannels() so it appears in the Supported Channels grid - Add LINE SVG logo icon (src/assets/channels/line.svg) - Add LINE logo case to ChannelLogo in both Channels page and ChannelConfigModal - Add LINE to ensurePluginAllowlist (plugins.allow + plugins.enabled) - Add validateLineCredentials via LINE Messaging API /v2/bot/info - Add LINE-specific config validation in validateChannelConfig - Add ensureLinePluginInstalled and register in ALL_BUNDLED_PLUGINS - Add LINE plugin install check in POST /api/channels/config route (soft warning) Co-authored-by: Haze <hazeone@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds full LINE messaging channel support to the Channels page, placed last in the supported channels grid (after QQ Bot). LINE uses the LINE Messaging API with Channel Access Token and Channel Secret for authentication.
Changes across 7 files:
Frontend (renderer)
src/types/channel.ts— Added'line'togetPrimaryChannels()so it appears in the Supported Channels gridsrc/assets/channels/line.svg— New LINE SVG logo icon (official LINE chat bubble mark)src/pages/Channels/index.tsx— Added LINE icon import andcase 'line':toChannelLogosrc/components/channels/ChannelConfigModal.tsx— Added LINE icon import andcase 'line':to modalChannelLogoBackend (main process)
electron/utils/channel-config.ts— Added LINE toensurePluginAllowlist, addedvalidateLineCredentials(callsapi.line.me/v2/bot/info), and LINE-specific config validation invalidateChannelConfigelectron/utils/plugin-install.ts— AddedensureLinePluginInstalledand registered it inALL_BUNDLED_PLUGINSelectron/api/routes/channels.ts— Added LINE plugin install check inPOST /api/channels/config(soft warning if plugin not found locally, config still saves)Notes
CHANNEL_META,CHANNEL_ICONS,CHANNEL_NAMES,CHANNEL_UNIQUE_CREDENTIAL_KEY, and i18n strings (en/zh/ja) were already present in the codebase — this PR wires them into the UI and backend logic.Related Issue(s)
N/A
Type of Change
Validation
pnpm run typecheck— passespnpm run lint— passespnpm test— all 250 tests pass (47 test files)Checklist