feat: add triggers support for shift actions

[pepordev]

Fixes #1346

Summary by CodeRabbit

• New Features
  • Shift actions are now available for axis and trigger mapping, enabling advanced controller customization options.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[coderabbitai]

Walkthrough

This change enables trigger buttons to support Shift actions in HandheldCompanion. It adds axis-based shift detection to LayoutManager, implements Shift action handling in TriggerMappingViewModel, and enables the previously-disabled Shift option in the trigger mapping UI template.

Changes

Cohort / File(s)	Summary
UI Template Configuration HandheldCompanion/Views/TemplatesDictionary.xaml	Enables the Shift action type option in TriggerMappingTemplate by changing IsEnabled from False to True
Trigger Mapping ViewModel Logic HandheldCompanion/ViewModels/Layout/Mappings/TriggerMappingViewModel.cs	Adds Shift action handling: initializes ShiftActions when ActionType is Shift, builds list of ShiftSlot targets (excluding None and Any), selects matching target, and updates Targets/SelectedTarget accordingly
Layout Manager Shift Processing HandheldCompanion/Managers/LayoutManager.cs	Introduces axis-based shift detection loop that processes ShiftActions defined for axes, reads origin X/Y values, executes ShiftActions, and updates cumulative shiftSlot when activated

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

• Verify axis-based shift detection in LayoutManager executes correctly in sequence with existing button-based shift handling
• Confirm ShiftActions initialization logic in TriggerMappingViewModel matches expected ShiftSlot target behavior
• Validate that trigger buttons now accept Shift action type without regressions

Poem

🐰 A trigger once bound, now set truly free,
With Shift at its side, as it ought to be,
Axis flows smooth through the manager's care,
Views dance with logic, oh what a pair! ✨

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	You can run @coderabbitai generate docstrings to improve docstring coverage.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The PR title accurately and concisely describes the main change: adding support for shift actions on trigger buttons, which directly addresses the core issue.
Linked Issues check	✅ Passed	The code changes enable the Shift action option for triggers and add the necessary backend logic to handle shift actions in trigger mapping, directly addressing issue #1346's requirements.
Out of Scope Changes check	✅ Passed	All changes are directly scoped to enabling shift action support for trigger buttons; no unrelated modifications detected.

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

HandheldCompanion/Managers/LayoutManager.cs (1)

575-603: Axis-based shift detection implemented correctly.

The implementation successfully extends shift detection to axes (triggers):

• Properly reads axis values using cached mappings
• Filters for ShiftActions to avoid double execution
• Maintains cumulative shiftSlot state consistent with button-based detection
• ShiftActions.Execute correctly evaluates motionThreshold (Gamepad.TriggerThreshold) and motionDirection (DeflectionDirection.Up) to determine shift activation

Consider refactoring to reduce duplication.

The axis value reading and layout preparation (lines 582-589) duplicates logic from the main axis processing loop (lines 663-671). Consider extracting this into a helper method:

private (float X, float Y, AxisLayout layout) PrepareAxisLayout(
    AxisLayoutFlags inFlag, 
    ControllerState controllerState)
{
    var xyIn = _axisXY[inFlag];
    var inX = controllerState.AxisState[xyIn.X];
    var inY = controllerState.AxisState[xyIn.Y];
    var inLayout = AxisLayout.Layouts[inFlag];
    inLayout.vector.X = inX;
    inLayout.vector.Y = inY;
    return (inX, inY, inLayout);
}

This would also improve consistency between button processing (shift detection integrated within main loop) and axis processing (current separate pre-pass approach).

📜 Review details

Configuration used: defaults

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between f6fbcdd and 607f1ef.

📒 Files selected for processing (3)

• HandheldCompanion/Managers/LayoutManager.cs (1 hunks)
• HandheldCompanion/ViewModels/Layout/Mappings/TriggerMappingViewModel.cs (3 hunks)
• HandheldCompanion/Views/TemplatesDictionary.xaml (1 hunks)

🧰 Additional context used

🧠 Learnings (1)

📓 Common learnings

Learnt from: romracer
Repo: Valkirie/HandheldCompanion PR: 1012
File: HandheldCompanion/Devices/MSI/ClawA1M.cs:0-0
Timestamp: 2024-07-27T07:08:12.731Z
Learning: The `ClawA1M` class in the `HandheldCompanion` project has been refactored to improve readability and maintainability. Changes include the removal of `scope` as a private field, simplification by removing thread logic, encapsulation of WMI event monitoring setup and teardown in separate methods with proper exception handling, and marking `specialKeyWatcher` as nullable.

🧬 Code graph analysis (2)

HandheldCompanion/Managers/LayoutManager.cs (2)

HandheldCompanion/Inputs/AxisLayout.cs (3)

• AxisLayout (35-38)
• AxisLayout (40-43)
• AxisLayout (45-48)

HandheldCompanion/Actions/ShiftActions.cs (2)

• ShiftActions (28-39)
• ShiftActions (41-44)

HandheldCompanion/ViewModels/Layout/Mappings/TriggerMappingViewModel.cs (3)

HandheldCompanion/ViewModels/Layout/Mappings/MappingViewModel.cs (1)

• MappingTargetViewModel (15-24)

HandheldCompanion/Utils/EnumUtils.cs (2)

• EnumUtils (10-64)
• GetDescriptionFromEnumValue (13-49)

HandheldCompanion/Extensions/UIThreadExtensions.cs (1)

• ReplaceWith (9-19)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

• GitHub Check: Build and Release

🔇 Additional comments (3)

HandheldCompanion/Views/TemplatesDictionary.xaml (1)

2104-2104: LGTM! Shift action now enabled for triggers.

This change directly addresses issue #1346 by enabling the previously disabled Shift option for trigger mappings. The change is properly supported by the corresponding ViewModel and Manager implementations.

HandheldCompanion/ViewModels/Layout/Mappings/TriggerMappingViewModel.cs (2)

184-208: LGTM! Shift action initialization follows established patterns.

The implementation correctly:

• Creates a ShiftActions instance with appropriate threshold and direction for trigger inputs
• Builds a filtered list of valid ShiftSlot targets (excluding None and Any)
• Maintains consistency with other action type handlers in this method

---

244-247: LGTM! Target assignment correctly updates ShiftSlot.

The implementation properly synchronizes the selected ShiftSlot back to the action, maintaining the two-way binding pattern used throughout this class.