KS-1-5 Перевод секунд в стандартный режим отображения#5
Open
VaisDevApp wants to merge 1 commit intomasterfrom
Open
KS-1-5 Перевод секунд в стандартный режим отображения#5VaisDevApp wants to merge 1 commit intomasterfrom
VaisDevApp wants to merge 1 commit intomasterfrom
Conversation
ievetrov
suggested changes
Nov 21, 2023
ievetrov
left a comment
ievetrov
left a comment
There was a problem hiding this comment.
Подсчет переменных корректный, как и результат работы программы. Но есть пара замечаний
| package lesson_1 | ||
|
|
||
| fun main() { | ||
| val seconds: Short = 5409 |
There was a problem hiding this comment.
что-то маловато секунд, обычно пишут 106 минут (6360) - или это открытый космос? )
| val hours: Int = seconds / 3600 | ||
| val minuts: Int = (seconds - hours * 3600) / 60 | ||
| val remainsSeconds = seconds - hours * 3600 - minuts * 60 | ||
| println("0$hours:$minuts:0$remainsSeconds") |
There was a problem hiding this comment.
в данном случае вывод будет корректный, но данный println не универсальный.
Давай применим "%02d...".format(...)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.