Feature/13 - added Rename Button to Decks#193
Open
g4ttsu wants to merge 3 commits intoVTES-JOL:masterfrom
Open
Feature/13 - added Rename Button to Decks#193g4ttsu wants to merge 3 commits intoVTES-JOL:masterfrom
g4ttsu wants to merge 3 commits intoVTES-JOL:masterfrom
Conversation
VTES-JOL#183: changed the rowspan attribute to the dynamic value of the player count
- DeckserverRemote added rename Deck Method saves new deck with same content and deletes old deck - added button to each Deck that changes deckName into Input and will trigger renameDeck
Collaborator
|
I might have to check this one a bit, to make sure deck names are not keys for registration entries, i think it's deck ID but I'll check |
Contributor
Author
|
I wasnt bold enough to change the name directly in the stored data because I was not sure how the name change of an existing/used deck might interact and effect the jol status. But as far as i understand the code during the registration process a copy of the used deck is copied into the game folder from that point on the actual deck in the deck list has no longer any effect on that registered deck. Thats as well my experience with changing my deck after registration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Feature #13: Currently its not possible to rename a deck. Added a button beside the delete Deck button that will change the DeckName to an InputField. Change Deck Names can so be changed by clicking on the Rename Deck Button again or by hitting Enter