Skip to content

Conversation

@kdesoto-astro
Copy link
Member

@kdesoto-astro kdesoto-astro commented Jul 20, 2023

Change Description

Code Quality

  • I have read the Contribution Guide
  • My code follows the code style of this project
  • My code builds (or compiles) cleanly without any errors or warnings
  • My code contains relevant comments and necessary documentation

@kdesoto-astro kdesoto-astro linked an issue Jul 20, 2023 that may be closed by this pull request
5 tasks
@kdesoto-astro kdesoto-astro self-assigned this Jul 20, 2023
@codecov
Copy link

codecov bot commented Jul 20, 2023

Codecov Report

Merging #36 (5610f2e) into main (42d00b0) will increase coverage by 6.66%.
The diff coverage is 1.07%.

@@            Coverage Diff             @@
##             main      #36      +/-   ##
==========================================
+ Coverage   23.03%   29.70%   +6.66%     
==========================================
  Files          11       18       +7     
  Lines        2097     2377     +280     
==========================================
+ Hits          483      706     +223     
- Misses       1614     1671      +57     
Impacted Files Coverage Δ
src/superphot_plus/custom_mala.py 0.00% <0.00%> (ø)
src/superphot_plus/fit_flowmc.py 0.00% <0.00%> (ø)
src/superphot_plus/constants.py 100.00% <100.00%> (ø)

... and 14 files with indirect coverage changes

@kdesoto-astro
Copy link
Member Author

Part 1 - without complete documentation/test cases but working. Merging so I can create an updated branch to finish this up

@kdesoto-astro kdesoto-astro marked this pull request as ready for review July 24, 2023 15:38
@kdesoto-astro kdesoto-astro changed the title Initial code, grad calculations in RFspline creates nan's somewhere Version 1 of flowMC code, adds custom MALA kernel too Jul 24, 2023
@kdesoto-astro kdesoto-astro requested review from hombit and villrv July 24, 2023 15:54
@delucchi-cmu delucchi-cmu mentioned this pull request Sep 20, 2023
4 tasks
@hombit hombit removed their request for review May 9, 2025 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add flowMC to the sampling options for light curve fits

2 participants