fix: load robot/team configs correctly in Docker installs #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When installed to /usr/local/bin, applicationDirPath changes and ../config is not valid. Add fallback search paths (e.g., /usr/local/share/grsim/config) to prevent default robot geometry.
fix(config): make robot ini lookup work after install
Ship team .ini files to /usr/local/share/grsim/config and ensure ~/.grsim.xml is created from template. Prevents fallback to default robot geometry (giant robots) inside containers.
fix: load robot/team configs correctly in Docker installs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🐛 Bugfix: FIRASim Docker loads correct robot geometry/configs
What was the problem?
When running FIRASim inside Docker, robot geometry was loaded with fallback defaults (e.g. radius/height),
causing robots to appear giant compared to native builds.
Root cause: installed binary runs from
/usr/local/bin, soqApp->applicationDirPath()changes and the appmay not find team
.inifiles (e.g.Parsian.ini) and/or the~/.grsim.xmlfile. This triggers defaultvalues in
loadRobotSettings().What changed?
firasim.xml) inside the image and copy it to~/.grsim.xmlon first run..inifiles are available in the installed path expected by the app(e.g.
/usr/local/share/grsim/config).How to test
X11 (host display)
xhost +local:docker docker run --rm -it \ -e DISPLAY=$DISPLAY \ -v /tmp/.X11-unix:/tmp/.X11-unix \ --device /dev/dri \ taurabots/firasim:latest