Skip to content

use ActionUpdateThread.BGT in actions to fix IDE errors #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vldF merged 3 commits into from
Jul 28, 2025
Merged

use ActionUpdateThread.BGT in actions to fix IDE errors #65

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b610af6
set all actions update thread to the BGT
vldF Jul 24, 2025
055bef9
make `getActionUpdateThread` one-line function
vldF Jul 25, 2025
5410677
Add TODO to UsagesBaseFinder
vldF Jul 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/main/kotlin/com/vk/modulite/actions/NewModuliteAction.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
package com.vk.modulite.actions

import com.intellij.icons.AllIcons
import com.intellij.openapi.actionSystem.ActionUpdateThread
import com.intellij.openapi.actionSystem.AnAction
import com.intellij.openapi.actionSystem.AnActionEvent
import com.intellij.openapi.actionSystem.CommonDataKeys
Expand All @@ -16,4 +17,6 @@ class NewModuliteAction : AnAction(
val folder = e.getData(CommonDataKeys.VIRTUAL_FILE) ?: return
ModuliteBuilder(project).startBuild(folder, fromSource = false)
}

override fun getActionUpdateThread() = ActionUpdateThread.BGT
}
3 changes: 3 additions & 0 deletions src/main/kotlin/com/vk/modulite/actions/NewModuliteFromFolderAction.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
package com.vk.modulite.actions

import com.intellij.icons.AllIcons
import com.intellij.openapi.actionSystem.ActionUpdateThread
import com.intellij.openapi.actionSystem.AnAction
import com.intellij.openapi.actionSystem.AnActionEvent
import com.intellij.openapi.actionSystem.CommonDataKeys
Expand Down Expand Up @@ -35,4 +36,6 @@ class NewModuliteFromFolderAction : AnAction(
return
}
}

override fun getActionUpdateThread() = ActionUpdateThread.BGT
}
4 changes: 3 additions & 1 deletion src/main/kotlin/com/vk/modulite/actions/RegenerateModuleRequiresAction.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
package com.vk.modulite.actions

import com.intellij.openapi.actionSystem.ActionUpdateThread
import com.intellij.openapi.actionSystem.AnAction
import com.intellij.openapi.actionSystem.AnActionEvent
import com.intellij.openapi.actionSystem.CommonDataKeys
Expand All @@ -17,7 +18,8 @@ class RegenerateModuleRequiresAction : AnAction() {
val file = e.getData(CommonDataKeys.VIRTUAL_FILE)
if (file == null || file.name != ".modulite.yaml") {
e.presentation.isEnabledAndVisible = false
return
}
}

override fun getActionUpdateThread() = ActionUpdateThread.BGT
}
3 changes: 3 additions & 0 deletions src/main/kotlin/com/vk/modulite/actions/SelectionBasedPsiElementAction.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
package com.vk.modulite.actions

import com.intellij.codeInsight.hint.HintManager
import com.intellij.openapi.actionSystem.ActionUpdateThread
import com.intellij.openapi.actionSystem.AnAction
import com.intellij.openapi.actionSystem.AnActionEvent
import com.intellij.openapi.actionSystem.CommonDataKeys
Expand Down Expand Up @@ -105,6 +106,8 @@ abstract class SelectionBasedPsiElementAction<T : PsiElement>(
return PsiTreeUtil.findElementOfClassAtRange(file, selectionStart, selectionEnd, myClass)
}

override fun getActionUpdateThread() = ActionUpdateThread.BGT

companion object {
private fun getEditor(e: AnActionEvent) = e.getData(CommonDataKeys.EDITOR)
private fun getPsiFile(e: AnActionEvent) = e.getData(CommonDataKeys.PSI_FILE)
Expand Down
1 change: 1 addition & 0 deletions src/main/kotlin/com/vk/modulite/actions/usages/base/UsagesBaseFinder.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,7 @@ abstract class UsagesBaseFinder {
it is DefaultSearchScopeProviders.CustomNamed
} ?: return

// TODO: remove `allowSlowOperations`
val scopes = SlowOperations.allowSlowOperations<List<SearchScope>, RuntimeException> {
provider.getSearchScopes(
element.project,
Expand Down
6 changes: 1 addition & 5 deletions src/main/kotlin/com/vk/modulite/actions/usages/php/FindSymbolUsagesInCurrentModuleAction.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,9 @@ package com.vk.modulite.actions.usages.php

import com.intellij.openapi.actionSystem.AnActionEvent
import com.intellij.openapi.actionSystem.CommonDataKeys
import com.intellij.util.SlowOperations
import com.jetbrains.php.lang.psi.elements.PhpPsiElement
import com.jetbrains.php.lang.psi.elements.Variable
import com.vk.modulite.actions.PhpPsiElementAction
import com.vk.modulite.modulite.Modulite
import com.vk.modulite.psi.extensions.files.containingModulite

class FindSymbolUsagesInCurrentModuleAction : PhpPsiElementAction<PhpPsiElement>(PhpPsiElement::class.java) {
Expand All @@ -20,9 +18,7 @@ class FindSymbolUsagesInCurrentModuleAction : PhpPsiElementAction<PhpPsiElement>
return
}

val modulite = SlowOperations.allowSlowOperations<Modulite?, RuntimeException> {
e.getData(CommonDataKeys.VIRTUAL_FILE)?.containingModulite(e.project!!)
}
val modulite = e.getData(CommonDataKeys.VIRTUAL_FILE)?.containingModulite(e.project!!)

if (modulite == null) {
e.presentation.isEnabledAndVisible = false
Expand Down
5 changes: 2 additions & 3 deletions src/main/kotlin/com/vk/modulite/actions/usages/yaml/FindAllowedSymbolUsagesInModuleAction.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
package com.vk.modulite.actions.usages.yaml

import com.intellij.openapi.actionSystem.ActionUpdateThread
import com.intellij.openapi.actionSystem.AnActionEvent
import com.intellij.openapi.actionSystem.CommonDataKeys
import com.intellij.util.SlowOperations
Expand All @@ -19,9 +20,7 @@ class FindAllowedSymbolUsagesInModuleAction : YamlPsiElementAction<YAMLQuotedTex
}

override fun update(e: AnActionEvent, element: YAMLQuotedText?) {
val modulite = SlowOperations.allowSlowOperations<Modulite?, RuntimeException> {
e.getData(CommonDataKeys.VIRTUAL_FILE)?.containingModulite(e.project!!)
}
val modulite = e.getData(CommonDataKeys.VIRTUAL_FILE)?.containingModulite(e.project!!)

if (element == null || modulite == null) {
e.presentation.isEnabledAndVisible = false
Expand Down
6 changes: 2 additions & 4 deletions src/main/kotlin/com/vk/modulite/actions/usages/yaml/FindModuleUsagesInCurrentModuleAction.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
package com.vk.modulite.actions.usages.yaml

import com.intellij.openapi.actionSystem.ActionUpdateThread
import com.intellij.openapi.actionSystem.AnActionEvent
import com.intellij.openapi.actionSystem.CommonDataKeys
import com.intellij.psi.PsiElement
Expand Down Expand Up @@ -40,10 +41,7 @@ class FindModuleUsagesInCurrentModuleAction : YamlPsiElementAction<YAMLQuotedTex
}

override fun update(e: AnActionEvent, element: YAMLQuotedText?) {
val module =
SlowOperations.allowSlowOperations<Modulite?, RuntimeException> {
e.getData(CommonDataKeys.VIRTUAL_FILE)?.containingModulite(e.project!!)
}
val module = e.getData(CommonDataKeys.VIRTUAL_FILE)?.containingModulite(e.project!!)

if (element == null || module == null) {
e.presentation.isEnabledAndVisible = false
Expand Down
6 changes: 2 additions & 4 deletions src/main/kotlin/com/vk/modulite/actions/usages/yaml/FindSymbolUsagesInCurrentModuleAction.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
package com.vk.modulite.actions.usages.yaml

import com.intellij.openapi.actionSystem.ActionUpdateThread
import com.intellij.openapi.actionSystem.AnActionEvent
import com.intellij.openapi.actionSystem.CommonDataKeys
import com.intellij.util.SlowOperations
Expand All @@ -15,10 +16,7 @@ class FindSymbolUsagesInCurrentModuleAction : YamlPsiElementAction<YAMLQuotedTex
}

override fun update(e: AnActionEvent, element: YAMLQuotedText?) {
val modulite =
SlowOperations.allowSlowOperations<Modulite?, RuntimeException> {
e.getData(CommonDataKeys.VIRTUAL_FILE)?.containingModulite(e.project!!)
}
val modulite = e.getData(CommonDataKeys.VIRTUAL_FILE)?.containingModulite(e.project!!)

if (element == null || modulite == null) {
e.presentation.isEnabledAndVisible = false
Expand Down