version 1.2.15 for PhpStorm 2025.1 with fix#66
Closed
Conversation
Hidanio
changed the title
Contributor
There was a problem hiding this comment.
take the config from https://github.com/VKCOM/TL-Schema-idea-plugin/blob/master/.github/workflows/build.yml please
| instrumentationTools() | ||
| pluginVerifier() | ||
| zipSigner() | ||
| phpstorm("2025.1") |
| intellijPlatform { | ||
| create(providers.gradleProperty("platformType"), providers.gradleProperty("platformVersion")) | ||
|
|
||
| create( |
...in/kotlin/com/vk/kphpstorm/kphptags/psi/factory/KphpDocTagTemplateClassElementTypeFactory.kt
Outdated
Show resolved
Hide resolved
| override fun shouldCreateStub(node: ASTNode): Boolean = | ||
| node.elementType == KphpDocElementTypes.kphpDocTagSimple | ||
|
|
||
| override fun createStub( |
Contributor
There was a problem hiding this comment.
your formatting style changes from file to file, pick one and use it everywhere
src/main/kotlin/com/vk/kphpstorm/kphptags/psi/KphpDocElementTypes.kt
Outdated
Show resolved
Hide resolved
Hidanio
force-pushed
the
hidanio/2025_1_migration_fix
branch
from
b35af89 to
7762ce1
Compare
vldF
approved these changes
Jul 24, 2025
ZemlyakovDmitry
approved these changes
Jul 24, 2025
vldF
requested changes
Jul 30, 2025
Contributor
vldF
left a comment
vldF
left a comment
There was a problem hiding this comment.
It seems this changes aren't valid. We're working on it
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jetbrains changed logic for PSI elements and thats why we should use psiTreeUtil for more stable behavior