Skip to content

[k2] add test for setlocale + minor changes to setlocale #1585

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
denisichh merged 3 commits into from
Apr 2, 2026
+96 −2
Merged

[k2] add test for setlocale + minor changes to setlocale #1585

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c59325b
added test
denisichh Mar 30, 2026
7fc1760
minor fix
denisichh Mar 31, 2026
3cfcf56
minor fix
denisichh Mar 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions runtime-light/stdlib/string/string-functions.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,12 +17,12 @@ inline string f$prepare_search_query(const string& query) noexcept {

inline Optional<string> f$setlocale(int64_t category, const string& locale) noexcept {
const int32_t i32category{static_cast<int32_t>(category)};
if (k2::uselocale(i32category, {locale.c_str(), locale.size()}) != k2::errno_ok) {
if (const std::string_view sv_locale{locale.c_str(), locale.size()}; sv_locale != "0" && k2::uselocale(i32category, sv_locale) != k2::errno_ok) {
return false;
}
const auto opt_locale_name{k2::current_locale_name(i32category)};
if (!opt_locale_name.has_value()) [[unlikely]] {
return false;
}
return opt_locale_name->data();
return string{opt_locale_name->data(), static_cast<string::size_type>(opt_locale_name->size())};
}
94 changes: 94 additions & 0 deletions tests/phpt/dl/1048_setlocale.php
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,94 @@
@ok
<?php

function setlocale_zero() {
var_dump("setlocale_zero");

var_dump("LC_CTYPE 0 -> " . setlocale(LC_CTYPE, "0"));
var_dump("LC_NUMERIC 0 -> " . setlocale(LC_NUMERIC, "0"));
var_dump("LC_TIME 0 -> " . setlocale(LC_TIME, "0"));
var_dump("LC_COLLATE 0 -> " . setlocale(LC_COLLATE, "0"));
var_dump("LC_MONETARY 0 -> " . setlocale(LC_MONETARY, "0"));
var_dump("LC_ALL 0 -> " . setlocale(LC_ALL, "0"));
}

function setlocale_return_empty() {
var_dump("setlocale_empty");

var_dump("LC_CTYPE \"\" -> " . setlocale(LC_CTYPE, ""));
var_dump("LC_NUMERIC \"\" -> " . setlocale(LC_NUMERIC, ""));
var_dump("LC_TIME \"\" -> " . setlocale(LC_TIME, ""));
var_dump("LC_COLLATE \"\" -> " . setlocale(LC_COLLATE, ""));
var_dump("LC_MONETARY \"\" -> " . setlocale(LC_MONETARY, ""));
var_dump("LC_ALL \"\" -> " . setlocale(LC_ALL, ""));

var_dump("check other (1)");
setlocale_zero();
}

function setlocale_return_set_ru_RU_CP1251() {
var_dump("setlocale_set_ru_RU_CP1251");

var_dump("LC_ALL \"\" -> " . setlocale(LC_ALL, "")); // unset all

var_dump("LC_CTYPE ru_RU.CP1251 -> " . setlocale(LC_CTYPE, "ru_RU.CP1251"));
var_dump("LC_CTYPE 0 -> " . setlocale(LC_CTYPE, "0"));

var_dump("LC_NUMERIC ru_RU.CP1251 -> " . setlocale(LC_NUMERIC, "ru_RU.CP1251"));
var_dump("LC_NUMERIC 0 -> " . setlocale(LC_NUMERIC, "0"));

var_dump("LC_TIME ru_RU.CP1251 -> " . setlocale(LC_TIME, "ru_RU.CP1251"));
var_dump("LC_TIME 0 -> " . setlocale(LC_TIME, "0"));

var_dump("LC_COLLATE ru_RU.CP1251 -> " . setlocale(LC_COLLATE, "ru_RU.CP1251"));
var_dump("LC_COLLATE 0 -> " . setlocale(LC_COLLATE, "0"));

var_dump("LC_MONETARY ru_RU.CP1251 -> " . setlocale(LC_MONETARY, "ru_RU.CP1251"));
var_dump("LC_MONETARY 0 -> " . setlocale(LC_MONETARY, "0"));

var_dump("LC_ALL 0 -> " . setlocale(LC_ALL, "0"));

var_dump("LC_ALL \"\" -> " . setlocale(LC_ALL, "")); // unset all

var_dump("check other (2)");
setlocale_zero();

var_dump("LC_ALL ru_RU.CP1251 -> " . setlocale(LC_ALL, "ru_RU.CP1251"));

var_dump("check other (3)");
setlocale_zero();

var_dump("LC_ALL \"\" -> " . setlocale(LC_ALL, "")); // unset all
}

function setlocale_return_correct_LC_ALL_changes() {
var_dump("setlocale_correct_LC_ALL_changes");

var_dump("LC_ALL en_US.UTF-8 -> " . setlocale(LC_ALL, "en_US.UTF-8"));
var_dump("LC_ALL 0 -> " . setlocale(LC_ALL, "0"));

var_dump("LC_COLLATE ru_RU.CP1251 -> " . setlocale(LC_COLLATE, "ru_RU.CP1251"));
var_dump("LC_ALL 0 -> " . setlocale(LC_ALL, "0"));

var_dump("LC_COLLATE en_US.UTF-8 -> " . setlocale(LC_COLLATE, "en_US.UTF-8"));
var_dump("LC_ALL 0 -> " . setlocale(LC_ALL, "0"));
}


function setlocale_numeric_cp1251() {
function printf_numeric() {
printf("%.2f\n", 1234.56);
}

var_dump("setlocale_numeric_cp1251");
setlocale(LC_NUMERIC, 'ru_RU.CP1251');
printf_numeric();
setlocale(LC_NUMERIC, 'C');
printf_numeric();
}


setlocale_return_empty();
setlocale_return_set_ru_RU_CP1251();
setlocale_return_correct_LC_ALL_changes();
setlocale_numeric_cp1251();
Loading