Skip to content

[k2] disable diagnostics for not found confdata key and wildcard #1581

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
apolyakov merged 1 commit into from
Mar 30, 2026
Merged

[k2] disable diagnostics for not found confdata key and wildcard #1581

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions runtime-light/stdlib/confdata/confdata-functions.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,6 @@ kphp::coro::task<mixed> f$confdata_get_value(string key) noexcept {
kphp::log::assertion(maybe_confdata_value.fetch(tlf));

if (!maybe_confdata_value.opt_value) { // no such key
kphp::log::warning("key isn't found: {}", confdata_get.key.value);
co_return mixed{};
}

Expand Down Expand Up @@ -121,11 +120,6 @@ kphp::coro::task<array<mixed>> f$confdata_get_values_by_any_wildcard(string wild
tl::Dictionary<tl::confdataValue> dict_confdata_value{};
kphp::log::assertion(dict_confdata_value.fetch(tlf));

if (dict_confdata_value.size() == 0) {
kphp::log::warning("wildcard doesn't match any key: {}", confdata_get_wildcard.wildcard.value);
co_return array<mixed>{};
}

array<mixed> result{array_size{static_cast<int64_t>(dict_confdata_value.size()), false}};
std::ranges::for_each(dict_confdata_value, [&result, wildcard_size = wildcard_view.size()](const auto& dict_field) noexcept {
kphp::log::assertion(dict_field.key.value.size() >= wildcard_size);
Expand Down
Loading