Skip to content

[k2] fix FP fetch builtins #1525

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Shamzik merged 1 commit into from
Feb 16, 2026
Merged

[k2] fix FP fetch builtins #1525

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 10 additions & 10 deletions runtime-light/stdlib/rpc/rpc-api.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,14 +75,6 @@ kphp::coro::task<class_instance<C$VK$TL$RpcResponse>> typed_rpc_tl_query_result_

// === server =====================================================================================

inline bool f$store_int(int64_t v) noexcept {
if (tl::is_int32_overflow(v)) [[unlikely]] {
kphp::log::warning("integer {} overflows int32, it will be cast to {}", v, static_cast<int32_t>(v));
}
tl::i32{.value = static_cast<int32_t>(v)}.store(RpcServerInstanceState::get().tl_storer);
return true;
}

inline bool f$store_byte(int64_t v) noexcept {
if (v < 0 || v > 255) [[unlikely]] {
kphp::log::warning("integer {} overflows uint8, it will be cast to {}", v, static_cast<uint8_t>(v));
Expand All @@ -91,6 +83,14 @@ inline bool f$store_byte(int64_t v) noexcept {
return true;
}

inline bool f$store_int(int64_t v) noexcept {
if (tl::is_int32_overflow(v)) [[unlikely]] {
kphp::log::warning("integer {} overflows int32, it will be cast to {}", v, static_cast<int32_t>(v));
}
tl::i32{.value = static_cast<int32_t>(v)}.store(RpcServerInstanceState::get().tl_storer);
return true;
}

inline bool f$store_long(int64_t v) noexcept {
tl::i64{.value = v}.store(RpcServerInstanceState::get().tl_storer);
return true;
Expand Down Expand Up @@ -148,7 +148,7 @@ inline int64_t f$fetch_long() noexcept {
return DEFAULT_VALUE;
}

inline double f$fetch_double() noexcept {
inline double f$fetch_float() noexcept {
static constexpr double DEFAULT_VALUE = 0.0;
if (tl::f32 val{}; val.fetch(RpcServerInstanceState::get().tl_fetcher)) [[likely]] {
return static_cast<double>(val.value);
Expand All @@ -157,7 +157,7 @@ inline double f$fetch_double() noexcept {
return DEFAULT_VALUE;
}

inline double f$fetch_float() noexcept {
inline double f$fetch_double() noexcept {
static constexpr double DEFAULT_VALUE = 0.0;
if (tl::f64 val{}; val.fetch(RpcServerInstanceState::get().tl_fetcher)) [[likely]] {
return val.value;
Expand Down
Loading