[k2] add f$preg_split to runtime-light#1451
Merged
Conversation
apolyakov
requested changes
Nov 2, 2025
apolyakov
reviewed
Nov 2, 2025
Contributor
apolyakov
left a comment
apolyakov
left a comment
There was a problem hiding this comment.
General comments:
- Please, don't use
std::for integral types likesize_t,int32_tetc - Please, add
noexceptspecifiers to all the functions - Please, think carefully about symbols names and visibility
Shamzik
force-pushed
the
kshamazov/pcre_functions
branch
from
5f70ac4 to
25cda02
Compare
Shamzik
commented
Nov 10, 2025
Contributor
Author
Shamzik
left a comment
Shamzik
left a comment
There was a problem hiding this comment.
There are fixes of preg_match_all and preg_replace
Need to separate
Shamzik
force-pushed
the
kshamazov/pcre_functions
branch
from
0f95d17 to
cc4cc52
Compare
apolyakov
reviewed
Nov 19, 2025
apolyakov
reviewed
Nov 25, 2025
Shamzik
force-pushed
the
kshamazov/pcre_functions
branch
2 times, most recently
from
36a4b88 to
375e746
Compare
Shamzik
force-pushed
the
kshamazov/pcre_functions
branch
from
45cc9cc to
e74e1ea
Compare
PetrShumilov
requested changes
Dec 9, 2025
Shamzik
force-pushed
the
kshamazov/pcre_functions
branch
from
99a07c1 to
8ce46e1
Compare
apolyakov
reviewed
Dec 9, 2025
apolyakov
reviewed
Dec 9, 2025
Shamzik
force-pushed
the
kshamazov/pcre_functions
branch
from
a5c81dc to
18a0c41
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The goal is to support the preg_split function in a light runtime.
Specified it with noexcept().