QA-10057 Remove users watcher groups-engine #369
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alk2017
force-pushed
the
a.chistov/remove-groups-engine/QA-10057
branch
from
3dd5dba to
f783d9d
Compare
-remove user watcher -user handler for alert message default quotas handler -fix merge del handler update quoats handler user handler method some fix -move without change method of devices to separate class -fix after move users method -move db.users method to separate class
Alk2017
force-pushed
the
a.chistov/remove-groups-engine/QA-10057
branch
from
f783d9d to
6e62164
Compare
irdkwmnsb
previously approved these changes
Sep 26, 2025
Collaborator
irdkwmnsb
left a comment
irdkwmnsb
left a comment
There was a problem hiding this comment.
Strictly better than what was before from the code perspective
| sendUserChange = (user, isAddedGroup, groups, action, targets) => { | ||
| function wireUserField() { | ||
| const wireUser = _.cloneDeep(user) | ||
| delete wireUser._id |
DaniilSmirnov
approved these changes
Oct 1, 2025
DaniilSmirnov
added a commit
that referenced
this pull request
Oct 21, 2025
* Wire initial typescript (#338) * Wire initial typescript * Fix types * Something works * Finishing touches * Linter fixes * Build problems * hotfix (#361) Co-authored-by: e.khalilov <e.khalilov@vkteam.ru> * Remove all DB connections from device side (#368) * hotfix imei * Decrease apt install list in dockerfile (#365) * remove gm and jdk11 * remove libs * Remove console-feed & react dependencies [backend only] (#366) * remove dep console-feed * minor fix * linter fix --------- Co-authored-by: e.khalilov <e.khalilov@vkteam.ru> * fix default quotas hierarchy QA-19255 (#367) * -fix quotas -fix lock -fix test -fix lint * -fix test --------- Co-authored-by: a.chistov <a.chistov@vk.team> * dev units without db conn * fix types * minor fix * minor fix * minor fix * remove useless sockets --------- Co-authored-by: Maksim Alzhanov <m.alzhanov@vk.team> Co-authored-by: Maxim <me@alzhanov.ru> Co-authored-by: Daniil <8039921+DaniilSmirnov@users.noreply.github.com> Co-authored-by: e.khalilov <e.khalilov@vkteam.ru> Co-authored-by: Alexey Chistov <33050834+Alk2017@users.noreply.github.com> Co-authored-by: a.chistov <a.chistov@vk.team> * fix device type & types (#374) Co-authored-by: e.khalilov <e.khalilov@vkteam.ru> * reconnect in ADBObserver (#376) Co-authored-by: e.khalilov <e.khalilov@vkteam.ru> * QA-10057 Remove users watcher groups-engine (#369) * -fix after rebase -remove user watcher -user handler for alert message default quotas handler -fix merge del handler update quoats handler user handler method some fix -move without change method of devices to separate class -fix after move users method -move db.users method to separate class * add missing db method --------- Co-authored-by: a.chistov <a.chistov@vk.team> Co-authored-by: e.khalilov <e.khalilov@vkteam.ru> * fix heartbeat (#377) Co-authored-by: e.khalilov <e.khalilov@vkteam.ru> * overrides dependencies (#378) Co-authored-by: e.khalilov <e.khalilov@vkteam.ru> * Automatic removal of disabled devices (#379) * clear dead devices * minor fix * revert api edits * revert ui (types) edits --------- Co-authored-by: e.khalilov <e.khalilov@vkteam.ru> * fix linkifyjs issue (#380) Co-authored-by: e.khalilov <e.khalilov@vkteam.ru> * Resolve conflicts (#381) * Hotfix: device imei issue (#371) * hotfix * minor fix * fix types * minor fix --------- Co-authored-by: e.khalilov <e.khalilov@vkteam.ru> * increase ram for v8 (#372) * hotfix (#373) Co-authored-by: e.khalilov <e.khalilov@vkteam.ru> * hotfix ADBObserver (#375) Co-authored-by: e.khalilov <e.khalilov@vkteam.ru> --------- Co-authored-by: e.khalilov <e.khalilov@vkteam.ru> Co-authored-by: Daniil <8039921+DaniilSmirnov@users.noreply.github.com> * Fixed transactions & minor optimizations (#382) * minor edits * fix transactions * minor fix * fix ts types --------- Co-authored-by: e.khalilov <e.khalilov@vkteam.ru> * Fix lint issues --------- Co-authored-by: Maxim <me@alzhanov.ru> Co-authored-by: Elmir Khalilov <52529096+e-khalilov@users.noreply.github.com> Co-authored-by: e.khalilov <e.khalilov@vkteam.ru> Co-authored-by: Maksim Alzhanov <m.alzhanov@vk.team> Co-authored-by: Alexey Chistov <33050834+Alk2017@users.noreply.github.com> Co-authored-by: a.chistov <a.chistov@vk.team>
e-khalilov
added a commit
that referenced
this pull request
Nov 17, 2025
* Develop to Master for 1.5.1 (#364) * Wire initial typescript (#338) * Wire initial typescript * Fix types * Something works * Finishing touches * Linter fixes * Build problems * hotfix (#361) Co-authored-by: e.khalilov <e.khalilov@vkteam.ru> * Remove all DB connections from device side (#368) * hotfix imei * Decrease apt install list in dockerfile (#365) * remove gm and jdk11 * remove libs * Remove console-feed & react dependencies [backend only] (#366) * remove dep console-feed * minor fix * linter fix --------- Co-authored-by: e.khalilov <e.khalilov@vkteam.ru> * fix default quotas hierarchy QA-19255 (#367) * -fix quotas -fix lock -fix test -fix lint * -fix test --------- Co-authored-by: a.chistov <a.chistov@vk.team> * dev units without db conn * fix types * minor fix * minor fix * minor fix * remove useless sockets --------- Co-authored-by: Maksim Alzhanov <m.alzhanov@vk.team> Co-authored-by: Maxim <me@alzhanov.ru> Co-authored-by: Daniil <8039921+DaniilSmirnov@users.noreply.github.com> Co-authored-by: e.khalilov <e.khalilov@vkteam.ru> Co-authored-by: Alexey Chistov <33050834+Alk2017@users.noreply.github.com> Co-authored-by: a.chistov <a.chistov@vk.team> * fix device type & types (#374) Co-authored-by: e.khalilov <e.khalilov@vkteam.ru> * reconnect in ADBObserver (#376) Co-authored-by: e.khalilov <e.khalilov@vkteam.ru> * QA-10057 Remove users watcher groups-engine (#369) * -fix after rebase -remove user watcher -user handler for alert message default quotas handler -fix merge del handler update quoats handler user handler method some fix -move without change method of devices to separate class -fix after move users method -move db.users method to separate class * add missing db method --------- Co-authored-by: a.chistov <a.chistov@vk.team> Co-authored-by: e.khalilov <e.khalilov@vkteam.ru> * fix heartbeat (#377) Co-authored-by: e.khalilov <e.khalilov@vkteam.ru> * overrides dependencies (#378) Co-authored-by: e.khalilov <e.khalilov@vkteam.ru> * Automatic removal of disabled devices (#379) * clear dead devices * minor fix * revert api edits * revert ui (types) edits --------- Co-authored-by: e.khalilov <e.khalilov@vkteam.ru> * fix linkifyjs issue (#380) Co-authored-by: e.khalilov <e.khalilov@vkteam.ru> * Resolve conflicts (#381) * Hotfix: device imei issue (#371) * hotfix * minor fix * fix types * minor fix --------- Co-authored-by: e.khalilov <e.khalilov@vkteam.ru> * increase ram for v8 (#372) * hotfix (#373) Co-authored-by: e.khalilov <e.khalilov@vkteam.ru> * hotfix ADBObserver (#375) Co-authored-by: e.khalilov <e.khalilov@vkteam.ru> --------- Co-authored-by: e.khalilov <e.khalilov@vkteam.ru> Co-authored-by: Daniil <8039921+DaniilSmirnov@users.noreply.github.com> * Fixed transactions & minor optimizations (#382) * minor edits * fix transactions * minor fix * fix ts types --------- Co-authored-by: e.khalilov <e.khalilov@vkteam.ru> * Fix lint issues --------- Co-authored-by: Maxim <me@alzhanov.ru> Co-authored-by: Elmir Khalilov <52529096+e-khalilov@users.noreply.github.com> Co-authored-by: e.khalilov <e.khalilov@vkteam.ru> Co-authored-by: Maksim Alzhanov <m.alzhanov@vk.team> Co-authored-by: Alexey Chistov <33050834+Alk2017@users.noreply.github.com> Co-authored-by: a.chistov <a.chistov@vk.team> * Hotfix: Fix broken import in ios Co-authored-by: e.khalilov <e.khalilov@vkteam.ru> * minitouch refactoring + TS --------- Co-authored-by: Daniil <8039921+DaniilSmirnov@users.noreply.github.com> Co-authored-by: Maxim <me@alzhanov.ru> Co-authored-by: e.khalilov <e.khalilov@vkteam.ru> Co-authored-by: Maksim Alzhanov <m.alzhanov@vk.team> Co-authored-by: Alexey Chistov <33050834+Alk2017@users.noreply.github.com> Co-authored-by: a.chistov <a.chistov@vk.team>
e-khalilov
added a commit
that referenced
this pull request
Nov 18, 2025
* Develop to Master for 1.5.1 (#364) * Wire initial typescript (#338) * Wire initial typescript * Fix types * Something works * Finishing touches * Linter fixes * Build problems * hotfix (#361) Co-authored-by: e.khalilov <e.khalilov@vkteam.ru> * Remove all DB connections from device side (#368) * hotfix imei * Decrease apt install list in dockerfile (#365) * remove gm and jdk11 * remove libs * Remove console-feed & react dependencies [backend only] (#366) * remove dep console-feed * minor fix * linter fix --------- Co-authored-by: e.khalilov <e.khalilov@vkteam.ru> * fix default quotas hierarchy QA-19255 (#367) * -fix quotas -fix lock -fix test -fix lint * -fix test --------- Co-authored-by: a.chistov <a.chistov@vk.team> * dev units without db conn * fix types * minor fix * minor fix * minor fix * remove useless sockets --------- Co-authored-by: Maksim Alzhanov <m.alzhanov@vk.team> Co-authored-by: Maxim <me@alzhanov.ru> Co-authored-by: Daniil <8039921+DaniilSmirnov@users.noreply.github.com> Co-authored-by: e.khalilov <e.khalilov@vkteam.ru> Co-authored-by: Alexey Chistov <33050834+Alk2017@users.noreply.github.com> Co-authored-by: a.chistov <a.chistov@vk.team> * fix device type & types (#374) Co-authored-by: e.khalilov <e.khalilov@vkteam.ru> * reconnect in ADBObserver (#376) Co-authored-by: e.khalilov <e.khalilov@vkteam.ru> * QA-10057 Remove users watcher groups-engine (#369) * -fix after rebase -remove user watcher -user handler for alert message default quotas handler -fix merge del handler update quoats handler user handler method some fix -move without change method of devices to separate class -fix after move users method -move db.users method to separate class * add missing db method --------- Co-authored-by: a.chistov <a.chistov@vk.team> Co-authored-by: e.khalilov <e.khalilov@vkteam.ru> * fix heartbeat (#377) Co-authored-by: e.khalilov <e.khalilov@vkteam.ru> * overrides dependencies (#378) Co-authored-by: e.khalilov <e.khalilov@vkteam.ru> * Automatic removal of disabled devices (#379) * clear dead devices * minor fix * revert api edits * revert ui (types) edits --------- Co-authored-by: e.khalilov <e.khalilov@vkteam.ru> * fix linkifyjs issue (#380) Co-authored-by: e.khalilov <e.khalilov@vkteam.ru> * Resolve conflicts (#381) * Hotfix: device imei issue (#371) * hotfix * minor fix * fix types * minor fix --------- Co-authored-by: e.khalilov <e.khalilov@vkteam.ru> * increase ram for v8 (#372) * hotfix (#373) Co-authored-by: e.khalilov <e.khalilov@vkteam.ru> * hotfix ADBObserver (#375) Co-authored-by: e.khalilov <e.khalilov@vkteam.ru> --------- Co-authored-by: e.khalilov <e.khalilov@vkteam.ru> Co-authored-by: Daniil <8039921+DaniilSmirnov@users.noreply.github.com> * Fixed transactions & minor optimizations (#382) * minor edits * fix transactions * minor fix * fix ts types --------- Co-authored-by: e.khalilov <e.khalilov@vkteam.ru> * Fix lint issues --------- Co-authored-by: Maxim <me@alzhanov.ru> Co-authored-by: Elmir Khalilov <52529096+e-khalilov@users.noreply.github.com> Co-authored-by: e.khalilov <e.khalilov@vkteam.ru> Co-authored-by: Maksim Alzhanov <m.alzhanov@vk.team> Co-authored-by: Alexey Chistov <33050834+Alk2017@users.noreply.github.com> Co-authored-by: a.chistov <a.chistov@vk.team> * Hotfix: Fix broken import in ios Co-authored-by: e.khalilov <e.khalilov@vkteam.ru> * fix vulnerable deps (#384) * sleep/wake event & fs checking fix * fix ports slicing --------- Co-authored-by: Daniil <8039921+DaniilSmirnov@users.noreply.github.com> Co-authored-by: Maxim <me@alzhanov.ru> Co-authored-by: e.khalilov <e.khalilov@vkteam.ru> Co-authored-by: Maksim Alzhanov <m.alzhanov@vk.team> Co-authored-by: Alexey Chistov <33050834+Alk2017@users.noreply.github.com> Co-authored-by: a.chistov <a.chistov@vk.team>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-remove user watcher
-user handler for alert message
default quotas handler
-fix merge
del handler
update quoats handler
user handler method
some fix
-move without change method of devices to separate class -fix after move users method
-move db.users method to separate class