Skip to content

Synchronize GH Actions with KphpStorm repo#249

Merged
vldF merged 5 commits intomasterfrom
vldf/gh-actions
Oct 17, 2025
Merged

Synchronize GH Actions with KphpStorm repo#249
vldF merged 5 commits intomasterfrom
vldf/gh-actions

Conversation

@vldF
Copy link
Copy Markdown
Contributor

@vldF vldF commented Oct 2, 2025

  1. Add the release workflow — the same as KphpStorm's one
  2. Introduce Qodana support — the same as KphpStorm's one
  3. Fix some critical code problems based on Qodana analysis. There are a plenty of code issues, however, they can't be fixed as easy as these
  4. Update project dictionaries to reduce false-positive Qodana issues findings
  5. Add project inspections profile — the same as KphpStorm's one

@vldF vldF self-assigned this Oct 2, 2025
@vldF vldF requested a review from a team as a code owner October 2, 2025 10:05
@vldF vldF added the enhancement New feature or request label Oct 2, 2025
@vldF vldF force-pushed the vldf/gh-actions branch from 6974b4d to 9cd5135 Compare October 2, 2025 10:18
@github-actions
Copy link
Copy Markdown

github-actions bot commented Oct 2, 2025

Qodana Community for JVM

It seems all right 👌

No new problems were found according to the checks applied

💡 Qodana analysis was run in the pull request mode: only the changed files were checked

View the detailed Qodana report

To be able to view the detailed Qodana report, you can either:

To get *.log files or any other Qodana artifacts, run the action with upload-result option set to true,
so that the action will upload the files as the job artifacts:

      - name: 'Qodana Scan'
        uses: JetBrains/qodana-action@v2025.1.1
        with:
          upload-result: true
Contact Qodana team

Contact us at qodana-support@jetbrains.com

@github-advanced-security
Copy link
Copy Markdown

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@vldF vldF requested review from Danil42Russia and Hidanio October 2, 2025 11:47
@Service
class DeployTestDomainService(private val project: Project) {
@Service(Service.Level.PROJECT)
class DeployTestDomainService private constructor(private val project: Project) {
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why? Something like global singleton?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We always need to pass Service.Level.PROJECT as the only argument of @Service annotation because in another case the service will be application-wide. Application services can't get project with their constructors

private constructor is the most convenient way to deny direct instance creation. This shows that developer must use some other way (e.g. getInstance()) to obtain it

@vldF vldF merged commit 27a4089 into master Oct 17, 2025
5 checks passed
@vldF vldF deleted the vldf/gh-actions branch October 17, 2025 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants