Conversation
vldF
commented
Oct 2, 2025
- Add the release workflow — the same as KphpStorm's one
- Introduce Qodana support — the same as KphpStorm's one
- Fix some critical code problems based on Qodana analysis. There are a plenty of code issues, however, they can't be fixed as easy as these
- Update project dictionaries to reduce false-positive Qodana issues findings
- Add project inspections profile — the same as KphpStorm's one
Qodana Community for JVMIt seems all right 👌 No new problems were found according to the checks applied 💡 Qodana analysis was run in the pull request mode: only the changed files were checked View the detailed Qodana reportTo be able to view the detailed Qodana report, you can either:
To get - name: 'Qodana Scan'
uses: JetBrains/qodana-action@v2025.1.1
with:
upload-result: trueContact Qodana teamContact us at qodana-support@jetbrains.com
|
|
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
| @Service | ||
| class DeployTestDomainService(private val project: Project) { | ||
| @Service(Service.Level.PROJECT) | ||
| class DeployTestDomainService private constructor(private val project: Project) { |
There was a problem hiding this comment.
Why? Something like global singleton?
There was a problem hiding this comment.
We always need to pass Service.Level.PROJECT as the only argument of @Service annotation because in another case the service will be application-wide. Application services can't get project with their constructors
private constructor is the most convenient way to deny direct instance creation. This shows that developer must use some other way (e.g. getInstance()) to obtain it